Update clippy to latest master by cmdln · Pull Request #52745 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation4 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
r? @oli-obk
There is a regression in the version in current nightly that falsely lints println! and writeln! that use named arguments, thinking all rhs values for the argument expressions are literals even when they are not. This update includes the fix for that.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
⚠️ Warning ⚠️
- These commits modify submodules.
📌 Commit 7fb0a52 has been approved by oli-obk
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request
Update clippy to latest master
r? @oli-obk
There is a regression in the version in current nightly that falsely lints println! and writeln! that use named arguments, thinking all rhs values for the argument expressions are literals even when they are not. This update includes the fix for that.
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request
Update clippy to latest master
r? @oli-obk
There is a regression in the version in current nightly that falsely lints println! and writeln! that use named arguments, thinking all rhs values for the argument expressions are literals even when they are not. This update includes the fix for that.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request
Update clippy to latest master
r? @oli-obk
There is a regression in the version in current nightly that falsely lints println! and writeln! that use named arguments, thinking all rhs values for the argument expressions are literals even when they are not. This update includes the fix for that.
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request
Update clippy to latest master
r? @oli-obk
There is a regression in the version in current nightly that falsely lints println! and writeln! that use named arguments, thinking all rhs values for the argument expressions are literals even when they are not. This update includes the fix for that.
bors added a commit that referenced this pull request
Rollup of 31 pull requests
Successful merges:
- #52332 (dead-code lint: say "constructed" for structs)
- #52340 (Document From trait implementations for OsStr, OsString, CString, and CStr)
- #52628 (Cleanup some rustdoc code)
- #52732 (Remove unstable and deprecated APIs)
- #52745 (Update clippy to latest master)
- #52756 (rustc: Disallow machine applicability in foreign macros)
- #52771 (Clarify thread::park semantics)
- #52810 ([NLL] Don't make "fake" match variables mutable)
- #52821 (pretty print for std::collections::vecdeque)
- #52822 (Fix From)
- #52824 (Fix -Wpessimizing-move warnings in rustllvm/PassWrapper)
- #52831 (remove references to AUTHORS.txt file)
- #52835 (Fix Alias intra doc ICE)
- #52842 (update comment)
- #52846 (Add timeout to use of
curlin bootstrap.py.) - #52851 (Make the tool_lints actually usable)
- #52853 (Improve bootstrap help on stages)
- #52859 (Use Vec::extend in SmallVec::extend when applicable)
- #52861 (Add targets for HermitCore (https://hermitcore.org) to the Rust compiler and port libstd to it.)
- #52867 (releases.md: fix 2 typos)
- #52870 (Implement Unpin for FutureObj and LocalFutureObj)
- #52876 (run-pass/const-endianness: negate before to_le())
- #52878 (Fix wrong issue number in the test name)
- #52883 (Include lifetime in mutability suggestion in NLL messages)
- #52904 (NLL: sort diagnostics by span)
- #52905 (Fix a typo in unsize.rs)
- #52907 (NLL: On "cannot move out of type" error, print original before rewrite)
- #52908 (Use SetLenOnDrop in Vec::truncate())
- #52914 (Only run the sparc-abi test on sparc)
- #52918 (Backport 1.27.2 release notes)
- #52929 (Update compatibility note for 1.28.0 to be correct)
Failed merges:
r? @ghost
pietroalbini added a commit to pietroalbini/rust that referenced this pull request
Update clippy to latest master
r? @oli-obk
There is a regression in the version in current nightly that falsely lints println! and writeln! that use named arguments, thinking all rhs values for the argument expressions are literals even when they are not. This update includes the fix for that.
bors added a commit that referenced this pull request
Rollup of 30 pull requests
Successful merges:
- #52340 (Document From trait implementations for OsStr, OsString, CString, and CStr)
- #52628 (Cleanup some rustdoc code)
- #52732 (Remove unstable and deprecated APIs)
- #52745 (Update clippy to latest master)
- #52771 (Clarify thread::park semantics)
- #52778 (Improve readability of serialize.rs)
- #52810 ([NLL] Don't make "fake" match variables mutable)
- #52821 (pretty print for std::collections::vecdeque)
- #52822 (Fix From)
- #52824 (Fix -Wpessimizing-move warnings in rustllvm/PassWrapper)
- #52825 (Make sure #47772 does not regress)
- #52831 (remove references to AUTHORS.txt file)
- #52842 (update comment)
- #52846 (Add timeout to use of
curlin bootstrap.py.) - #52851 (Make the tool_lints actually usable)
- #52853 (Improve bootstrap help on stages)
- #52859 (Use Vec::extend in SmallVec::extend when applicable)
- #52861 (Add targets for HermitCore (https://hermitcore.org) to the Rust compiler and port libstd to it.)
- #52867 (releases.md: fix 2 typos)
- #52870 (Implement Unpin for FutureObj and LocalFutureObj)
- #52876 (run-pass/const-endianness: negate before to_le())
- #52878 (Fix wrong issue number in the test name)
- #52883 (Include lifetime in mutability suggestion in NLL messages)
- #52888 (Use suggestions for shell format arguments)
- #52904 (NLL: sort diagnostics by span)
- #52905 (Fix a typo in unsize.rs)
- #52907 (NLL: On "cannot move out of type" error, print original before rewrite)
- #52914 (Only run the sparc-abi test on sparc)
- #52918 (Backport 1.27.2 release notes)
- #52929 (Update compatibility note for 1.28.0 to be correct)
Failed merges:
r? @ghost
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.