Improve error span for async type inference error by Aaron1011 · Pull Request #62383 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Fixes #62382

Previously, we would point at the spawn of the 'await' expression,
instead of the actual expression with an unknown type.

Fixes rust-lang#62382

Previously, we would point at the spawn of the 'await' expression, instead of the actual expression with an unknown type.

(rust_highfive has picked a reviewer for you, use r? to override)

📌 Commit 779308a has been approved by varkor

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Centril added a commit to Centril/rust that referenced this pull request

…arkor

Improve error span for async type inference error

Fixes rust-lang#62382

Previously, we would point at the spawn of the 'await' expression, instead of the actual expression with an unknown type.

Centril added a commit to Centril/rust that referenced this pull request

…arkor

Improve error span for async type inference error

Fixes rust-lang#62382

Previously, we would point at the spawn of the 'await' expression, instead of the actual expression with an unknown type.

bors added a commit that referenced this pull request

Rollup of 10 pull requests

Successful merges:

#62123 ( Remove needless lifetimes (std))
#62150 (Implement mem::{zeroed,uninitialized} in terms of MaybeUninit.)
#62169 (Derive which queries to save using the proc macro)
#62238 (Fix code block information icon position)
#62292 (Move async || ... closures into #![feature(async_closure)])
#62323 (Clarify unaligned fields in ptr::{read,write}_unaligned)
#62324 (Reduce reliance on await!(...) macro)
#62371 (Add tracking issue for Box::into_pin)
#62383 (Improve error span for async type inference error)
#62388 (Break out of the correct number of scopes in loops)

Failed merges:

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.