Fix invalid span generation when it should be div by GuillaumeGomez · Pull Request #64175 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation2 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Fixes #64146.

It changes basically nothing in the display... Can be checked with:

pub enum X { /// Some doc? /// /// with lines! Foo { /// a /// /// b x: u32, /// Doc! /// /// /// yolo /// y: String, }, /// Doc! /// /// /// yolo /// Bar(String), }

r? @Mark-Simulacrum

Interesting. I guess it seems fine. @bors r+ rollup

📌 Commit d4d5aa4 has been approved by Mark-Simulacrum

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Sep 5, 2019

Centril added a commit to Centril/rust that referenced this pull request

Sep 5, 2019

…-should-be-div, r=Mark-Simulacrum

Fix invalid span generation when it should be div

Fixes rust-lang#64146.

It changes basically nothing in the display... Can be checked with:

pub enum X {
    /// Some doc?
    ///
    /// with lines!
    Foo {
        /// a
        ///
        /// b
        x: u32,
        /// Doc!
        ///
        /// ```
        /// yolo
        /// ```
        y: String,
    },
    /// Doc!
    ///
    /// ```
    /// yolo
    /// ```
    Bar(String),
}

r? @Mark-Simulacrum

Centril added a commit to Centril/rust that referenced this pull request

Sep 5, 2019

…-should-be-div, r=Mark-Simulacrum

Fix invalid span generation when it should be div

Fixes rust-lang#64146.

It changes basically nothing in the display... Can be checked with:

pub enum X {
    /// Some doc?
    ///
    /// with lines!
    Foo {
        /// a
        ///
        /// b
        x: u32,
        /// Doc!
        ///
        /// ```
        /// yolo
        /// ```
        y: String,
    },
    /// Doc!
    ///
    /// ```
    /// yolo
    /// ```
    Bar(String),
}

r? @Mark-Simulacrum

bors added a commit that referenced this pull request

Sep 5, 2019

Rollup of 5 pull requests

Successful merges:

#63676 (Use wasi crate for Core API)
#64094 (Improve searching in rustdoc and add tests)
#64111 (or-patterns: Uniformly use PatKind::Or in AST & Fix/Cleanup resolve)
#64156 (Assume non-git LLVM is fresh if the stamp file exists)
#64175 (Fix invalid span generation when it should be div)

Failed merges:

#63806 (Upgrade rand to 0.7)

r? @ghost

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request

Sep 6, 2019

…-should-be-div, r=Mark-Simulacrum

Fix invalid span generation when it should be div

Fixes rust-lang#64146.

It changes basically nothing in the display... Can be checked with:

pub enum X {
    /// Some doc?
    ///
    /// with lines!
    Foo {
        /// a
        ///
        /// b
        x: u32,
        /// Doc!
        ///
        /// ```
        /// yolo
        /// ```
        y: String,
    },
    /// Doc!
    ///
    /// ```
    /// yolo
    /// ```
    Bar(String),
}

r? @Mark-Simulacrum

Centril added a commit to Centril/rust that referenced this pull request

Sep 6, 2019

…-should-be-div, r=Mark-Simulacrum

Fix invalid span generation when it should be div

Fixes rust-lang#64146.

It changes basically nothing in the display... Can be checked with:

pub enum X {
    /// Some doc?
    ///
    /// with lines!
    Foo {
        /// a
        ///
        /// b
        x: u32,
        /// Doc!
        ///
        /// ```
        /// yolo
        /// ```
        y: String,
    },
    /// Doc!
    ///
    /// ```
    /// yolo
    /// ```
    Bar(String),
}

r? @Mark-Simulacrum

bors added a commit that referenced this pull request

Sep 6, 2019

Rollup of 10 pull requests

Successful merges:

#63676 (Use wasi crate for Core API)
#64094 (Improve searching in rustdoc and add tests)
#64111 (or-patterns: Uniformly use PatKind::Or in AST & Fix/Cleanup resolve)
#64156 (Assume non-git LLVM is fresh if the stamp file exists)
#64161 (Point at variant on pattern field count mismatch)
#64174 (Add missing code examples on Iterator trait)
#64175 (Fix invalid span generation when it should be div)
#64186 (std: Improve downstream codegen in Command::env)
#64190 (fill metadata in rustc_lexer's Cargo.toml)
#64198 (Add Fuchsia to actually_monotonic)

Failed merges:

r? @ghost

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.