Deduplicate closure type errors by estebank · Pull Request #64937 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Closure typing obligations flow in both direcitons to properly infer
types. Because of this, we will get 2 type errors whenever there's
an unfulfilled obligation. To avoid this, we deduplicate them in the
InferCtxt.

Closure typing obligations flow in both direcitons to properly infer types. Because of this, we will get 2 type errors whenever there's an unfulfilled obligation. To avoid this, we deduplicate them in the InferCtxt.

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

📌 Commit 13e9b3d has been approved by Centril

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Oct 1, 2019

Centril added a commit to Centril/rust that referenced this pull request

Oct 1, 2019

Deduplicate closure type errors

Closure typing obligations flow in both direcitons to properly infer types. Because of this, we will get 2 type errors whenever there's an unfulfilled obligation. To avoid this, we deduplicate them in the InferCtxt.

Centril added a commit to Centril/rust that referenced this pull request

Oct 1, 2019

Deduplicate closure type errors

Closure typing obligations flow in both direcitons to properly infer types. Because of this, we will get 2 type errors whenever there's an unfulfilled obligation. To avoid this, we deduplicate them in the InferCtxt.

bors added a commit that referenced this pull request

Oct 1, 2019

Rollup of 10 pull requests

Successful merges:

• #63674 (syntax: Support modern attribute syntax in the meta matcher)
• #63931 (Stabilize macros in some more positions)
• #64887 (syntax: recover trailing | in or-patterns)
• #64895 (async/await: improve not-send errors)
• #64896 (Remove legacy grammar)
• #64907 (A small amount of tidying-up factored out from PR #64648)
• #64928 (Add tests for some issues)
• #64930 (Silence unreachable code lint from await desugaring)
• #64935 (Improve code clarity)
• #64937 (Deduplicate closure type errors)

Failed merges:

r? @ghost

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.