Stabilize const for integer {to,from}_{be,le,ne}_bytes methods by tspiteri · Pull Request #69373 · rust-lang/rust (original) (raw)

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

jonas-schievink added relnotes

Marks issues that should be documented in the release notes of the next release.

T-libs-api

Relevant to the library API team, which will review and decide on the PR/issue.

labels

Feb 22, 2020

All of these functions can be implemented simply and naturally as const functions, e.g. u32::from_le_bytes can be implemented as

(bytes[0] as u32)
    | (bytes[1] as u32) << 8
    | (bytes[2] as u32) << 16
    | (bytes[3] as u32) << 24

So stabilizing the constness will not expose that internally they are implemented using transmute which is not const in stable.

kennytm added the needs-fcp

This change is insta-stable, so needs a completed FCP to proceed.

label

Feb 23, 2020

rfcbot added the final-comment-period

In the final comment period and will be merged soon unless new substantive objections are raised.

label

Feb 23, 2020

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Mar 10, 2020

Centril added a commit to Centril/rust that referenced this pull request

Mar 11, 2020

…i-obk

Stabilize const for integer {to,from}_{be,le,ne}_bytes methods

All of these functions can be implemented simply and naturally as const functions, e.g. u32::from_le_bytes can be implemented as

(bytes[0] as u32)
    | (bytes[1] as u32) << 8
    | (bytes[2] as u32) << 16
    | (bytes[3] as u32) << 24

So stabilizing the constness will not expose that internally they are implemented using transmute which is not const in stable.

bors added a commit that referenced this pull request

Mar 11, 2020

Rollup of 10 pull requests

Successful merges:

• #66059 (mem::zeroed/uninit: panic on types that do not permit zero-initialization)
• #69373 (Stabilize const for integer {to,from}_{be,le,ne}_bytes methods)
• #69591 (Use TypeRelating for instantiating query responses)
• #69625 (Implement nth, last, and count for iter::Copied)
• #69645 (const forget tests)
• #69766 (Make Point Copy in arithmetic documentation)
• #69825 (make mem::discriminant const)
• #69859 (fix #62456)
• #69891 (Exhaustiveness checking, Matrix::push: recursively expand or-patterns)
• #69896 (parse: Tweak the function parameter edition check)

Failed merges:

r? @ghost

JohnTitor added a commit to JohnTitor/rust that referenced this pull request

Mar 13, 2020

…, r=dtolnay

Update stable-since version for const_int_conversion

Since rust-lang#69373 was not merged in time for 1.43.0 beta, update to since = "1.44.0".

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request

Jun 8, 2020

Pkgsrc changes:

• Remove a couple diffs which are now integrated upstream.
• Adjust cargo checksums after upstream upgrades.
• Belatedly bump the curl dependency
• Unset DESTDIR during the build phase, to work around a mysterious build bug deep in the bowels of llvm.
• Bump nearly all bootstraps to 1.43.1.

Upstream changes:

Version 1.44.0 (2020-06-04)

Language

• You can now use async/.await with #[no_std] enabled.
• Added the unused_braces lint.

Syntax-only changes

• Expansion-driven outline module parsing

#[cfg(FALSE)]
mod foo {
    mod bar {
        mod baz; // `foo/bar/baz.rs` doesn't exist, but no error!
    }
}

These are still rejected semantically, so you will likely receive an error but these changes can be seen and parsed by macros and conditional compilation.

Compiler

• Rustc now respects the -C codegen-units flag in incremental mode. Additionally when in incremental mode rustc defaults to 256 codegen units.
• Refactored catch_unwind, to have zero-cost unless unwinding is enabled and a panic is thrown.
• Added tier 3* support for the aarch64-unknown-none and aarch64-unknown-none-softfloat targets.
• Added tier 3 support for arm64-apple-tvos and x86_64-apple-tvos targets.

Libraries

• Special cased vec![] to map directly to Vec::new(). This allows vec![] to be able to be used in const contexts.
• convert::Infallible now implements Hash.
• OsString now implements DerefMut and IndexMut returning a &mut OsStr.
• Unicode 13 is now supported.
• String now implements From<&mut str>.
• IoSlice now implements Copy.
• Vec<T> now implements From<[T; N]>. Where N is less than 32.
• proc_macro::LexError now implements fmt::Display and Error.
• from_le_bytes, to_le_bytes, from_be_bytes, to_be_bytes, from_ne_bytes, and to_ne_bytes methods are now const for all integer types.

Stabilized APIs

• PathBuf::with_capacity
• PathBuf::capacity
• PathBuf::clear
• PathBuf::reserve
• PathBuf::reserve_exact
• PathBuf::shrink_to_fit
• f32::to_int_unchecked
• f64::to_int_unchecked
• Layout::align_to
• Layout::pad_to_align
• Layout::array
• Layout::extend

Cargo

• Added the cargo tree command which will print a tree graph of your dependencies. E.g.

    mdbook v0.3.2 (/Users/src/rust/mdbook)
  +-- ammonia v3.0.0
  |   +-- html5ever v0.24.0
  |   |   +-- log v0.4.8
  |   |   |   +-- cfg-if v0.1.9
  |   |   +-- mac v0.1.1
  |   |   +-- markup5ever v0.9.0
  |   |       +-- log v0.4.8 (*)
  |   |       +-- phf v0.7.24
  |   |       |   +-- phf_shared v0.7.24
  |   |       |       +-- siphasher v0.2.3
  |   |       |       +-- unicase v1.4.2
  |   |       |           [build-dependencies]
  |   |       |           +-- version_check v0.1.5
  ...

  You can also display dependencies on multiple versions of the same crate with cargo tree -d (short for cargo tree --duplicates).

Misc

• Rustdoc now allows you to specify --crate-version to have rustdoc include the version in the sidebar.

Compatibility Notes

• Rustc now correctly generates static libraries on Windows GNU targets with the .a extension, rather than the previous .lib.
• Removed the -C no_integrated_as flag from rustc.
• The file_name property in JSON output of macro errors now points the actual source file rather than the previous format of <NAME macros>. Note: this may not point a file that actually exists on the user's system.
• The minimum required external LLVM version has been bumped to LLVM 8.
• mem::{zeroed, uninitialised} will now panic when used with types that do not allow zero initialization such as NonZeroU8. This was previously a warning.
• In 1.45.0 (the next release) converting a f64 to u32 using the as operator has been defined as a saturating operation. This was previously undefined behaviour, you can use the {f64, f32}::to_int_unchecked methods to continue using the current behaviour which may desirable in rare performance sensitive situations.

Internal Only

These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools.

• dep_graph Avoid allocating a set on when the number reads are small.
• Replace big JS dict with JSON parsing.

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request

Jun 9, 2020

Version 1.44.0 (2020-06-04)

Language

• You can now use async/.await with #[no_std] enabled.
• Added the unused_braces lint.

Syntax-only changes

• Expansion-driven outline module parsing

#[cfg(FALSE)]
mod foo {
    mod bar {
        mod baz; // `foo/bar/baz.rs` doesn't exist, but no error!
    }
}

These are still rejected semantically, so you will likely receive an error but these changes can be seen and parsed by macros and conditional compilation.

Compiler

• Rustc now respects the -C codegen-units flag in incremental mode. Additionally when in incremental mode rustc defaults to 256 codegen units.
• Refactored catch_unwind to have zero-cost, unless unwinding is enabled and a panic is thrown.
• Added tier 3* support for the aarch64-unknown-none and aarch64-unknown-none-softfloat targets.
• Added tier 3 support for arm64-apple-tvos and x86_64-apple-tvos targets.

Libraries

• Special cased vec![] to map directly to Vec::new(). This allows vec![] to be able to be used in const contexts.
• convert::Infallible now implements Hash.
• OsString now implements DerefMut and IndexMut returning a &mut OsStr.
• Unicode 13 is now supported.
• String now implements From<&mut str>.
• IoSlice now implements Copy.
• Vec<T> now implements From<[T; N]>. Where N is at most 32.
• proc_macro::LexError now implements fmt::Display and Error.
• from_le_bytes, to_le_bytes, from_be_bytes, to_be_bytes, from_ne_bytes, and to_ne_bytes methods are now const for all integer types.

Stabilized APIs

• PathBuf::with_capacity
• PathBuf::capacity
• PathBuf::clear
• PathBuf::reserve
• PathBuf::reserve_exact
• PathBuf::shrink_to_fit
• f32::to_int_unchecked
• f64::to_int_unchecked
• Layout::align_to
• Layout::pad_to_align
• Layout::array
• Layout::extend

Cargo

• Added the cargo tree command which will print a tree graph of your dependencies. E.g.

    mdbook v0.3.2 (/Users/src/rust/mdbook)
  ├── ammonia v3.0.0
  │   ├── html5ever v0.24.0
  │   │   ├── log v0.4.8
  │   │   │   └── cfg-if v0.1.9
  │   │   ├── mac v0.1.1
  │   │   └── markup5ever v0.9.0
  │   │       ├── log v0.4.8 (*)
  │   │       ├── phf v0.7.24
  │   │       │   └── phf_shared v0.7.24
  │   │       │       ├── siphasher v0.2.3
  │   │       │       └── unicase v1.4.2
  │   │       │           [build-dependencies]
  │   │       │           └── version_check v0.1.5
  ...

  You can also display dependencies on multiple versions of the same crate with cargo tree -d (short for cargo tree --duplicates).

Misc

• Rustdoc now allows you to specify --crate-version to have rustdoc include the version in the sidebar.

Compatibility Notes

• Rustc now correctly generates static libraries on Windows GNU targets with the .a extension, rather than the previous .lib.
• Removed the -C no_integrated_as flag from rustc.
• The file_name property in JSON output of macro errors now points the actual source file rather than the previous format of <NAME macros>. Note: this may not point to a file that actually exists on the user's system.
• The minimum required external LLVM version has been bumped to LLVM 8.
• mem::{zeroed, uninitialised} will now panic when used with types that do not allow zero initialization such as NonZeroU8. This was previously a warning.
• In 1.45.0 (the next release) converting a f64 to u32 using the as operator has been defined as a saturating operation. This was previously undefined behaviour, but you can use the {f64, f32}::to_int_unchecked methods to continue using the current behaviour, which may be desirable in rare performance sensitive situations.

Internal Only

These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools.

• dep_graph Avoid allocating a set on when the number reads are small.
• Replace big JS dict with JSON parsing.

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request

Jul 6, 2020

Pkgsrc changes:

• Remove the clutter caused by the cross-compile setup from Makefile (Now consigned to my own private cross.mk file.)
• Remove a couple of patches which are now integrated upstream.
• Minor adjustments to a couple of other patches.
• Adjust cargo checksums after upstream upgrades.
• Belatedly bump the curl dependency
• If doing a "dist" build, unset DESTDIR during the build phase, to work around a mysterious build bug deep in the bowels of llvm, causing llvm tools to be installed to a directory unexpecetd by the rest of the rust build, ref. rust-lang/rust#73132 A "dist" build is not expected to be followed by an "install".
• Bump nearly all bootstraps to 1.43.1; NetBSD earmv7hf bootstrap bumped to 1.44.0, as that one now finally builds and works.

Upstream changes:

Version 1.44.0 (2020-06-04)

Language

• You can now use async/.await with #[no_std] enabled.
• Added the unused_braces lint.

Syntax-only changes

• Expansion-driven outline module parsing

#[cfg(FALSE)]
mod foo {
    mod bar {
        mod baz; // `foo/bar/baz.rs` doesn't exist, but no error!
    }
}

These are still rejected semantically, so you will likely receive an error but these changes can be seen and parsed by macros and conditional compilation.

Compiler

• Rustc now respects the -C codegen-units flag in incremental mode. Additionally when in incremental mode rustc defaults to 256 codegen units.
• Refactored catch_unwind, to have zero-cost unless unwinding is enabled and a panic is thrown.
• Added tier 3* support for the aarch64-unknown-none and aarch64-unknown-none-softfloat targets.
• Added tier 3 support for arm64-apple-tvos and x86_64-apple-tvos targets.

Libraries

• Special cased vec![] to map directly to Vec::new(). This allows vec![] to be able to be used in const contexts.
• convert::Infallible now implements Hash.
• OsString now implements DerefMut and IndexMut returning a &mut OsStr.
• Unicode 13 is now supported.
• String now implements From<&mut str>.
• IoSlice now implements Copy.
• Vec<T> now implements From<[T; N]>. Where N is less than 32.
• proc_macro::LexError now implements fmt::Display and Error.
• from_le_bytes, to_le_bytes, from_be_bytes, to_be_bytes, from_ne_bytes, and to_ne_bytes methods are now const for all integer types.

Stabilized APIs

• PathBuf::with_capacity
• PathBuf::capacity
• PathBuf::clear
• PathBuf::reserve
• PathBuf::reserve_exact
• PathBuf::shrink_to_fit
• f32::to_int_unchecked
• f64::to_int_unchecked
• Layout::align_to
• Layout::pad_to_align
• Layout::array
• Layout::extend

Cargo

• Added the cargo tree command which will print a tree graph of your dependencies. E.g.

    mdbook v0.3.2 (/Users/src/rust/mdbook)
  +-- ammonia v3.0.0
  |   +-- html5ever v0.24.0
  |   |   +-- log v0.4.8
  |   |   |   +-- cfg-if v0.1.9
  |   |   +-- mac v0.1.1
  |   |   +-- markup5ever v0.9.0
  |   |       +-- log v0.4.8 (*)
  |   |       +-- phf v0.7.24
  |   |       |   +-- phf_shared v0.7.24
  |   |       |       +-- siphasher v0.2.3
  |   |       |       +-- unicase v1.4.2
  |   |       |           [build-dependencies]
  |   |       |           +-- version_check v0.1.5
  ...

  You can also display dependencies on multiple versions of the same crate with cargo tree -d (short for cargo tree --duplicates).

Misc

• Rustdoc now allows you to specify --crate-version to have rustdoc include the version in the sidebar.

Compatibility Notes

• Rustc now correctly generates static libraries on Windows GNU targets with the .a extension, rather than the previous .lib.
• Removed the -C no_integrated_as flag from rustc.
• The file_name property in JSON output of macro errors now points the actual source file rather than the previous format of <NAME macros>. Note: this may not point a file that actually exists on the user's system.
• The minimum required external LLVM version has been bumped to LLVM 8.
• mem::{zeroed, uninitialised} will now panic when used with types that do not allow zero initialization such as NonZeroU8. This was previously a warning.
• In 1.45.0 (the next release) converting a f64 to u32 using the as operator has been defined as a saturating operation. This was previously undefined behaviour, you can use the {f64, f32}::to_int_unchecked methods to continue using the current behaviour which may desirable in rare performance sensitive situations.

Internal Only

These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools.

• dep_graph Avoid allocating a set on when the number reads are small.
• Replace big JS dict with JSON parsing.

JohnTitor added a commit to JohnTitor/rust that referenced this pull request

Aug 8, 2020

clean up const-hacks in int endianess conversion functions

Cleans up the const hacks added in rust-lang#69373.

r? @oli-obk