test(pattern): add tests for combinations of pattern features by thekuom · Pull Request #69690 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation6 Commits3 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Reference issue #67311

Tests combinations of the following pattern features:

• bindings_after_at
• or_patterns
• slice_patterns
• box_patterns

r? @Centril

Reference issue rust-lang#67311

Tests combinations of the following pattern features:

• bindings_after_at
• or_patterns
• slice_patterns
• box_patterns

Some of the nested OR paths were being missed

This comment has been minimized.

Thanks, these look great! @bors r+ rollup & cc @matthewjasper for awareness.

By the way, would you by any chance also like to extend the borrow checking test suites for these features?

📌 Commit ea7b3c3 has been approved by Centril

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Mar 6, 2020

@Centril thanks! I can do those tests as well

Centril added a commit to Centril/rust that referenced this pull request

Mar 7, 2020

…after-at-tests, r=Centril

test(pattern): add tests for combinations of pattern features

Reference issue rust-lang#67311

Tests combinations of the following pattern features:

• bindings_after_at
• or_patterns
• slice_patterns
• box_patterns

r? @Centril

bors added a commit that referenced this pull request

Mar 7, 2020

Rollup of 9 pull requests

Successful merges:

• #67741 (When encountering an Item in a pat context, point at the item def)
• #68985 (Parse & reject postfix operators after casts)
• #69656 (Use .next() instead of .nth(0) on iterators.)
• #69680 (rustc_expand: Factor out Annotatable::into_tokens to a separate method)
• #69690 (test(pattern): add tests for combinations of pattern features)
• #69706 (Use subslice patterns in slice methods)
• #69727 (Avoid using unwrap() in suggestions)
• #69754 (Update deprecation version to 1.42 for Error::description)
• #69782 (Don't redundantly repeat field names (clippy::redundant_field_names))

Failed merges:

r? @ghost

thekuom deleted the test/67311-extend-bindings-after-at-tests branch

March 8, 2020 02:29

cc some of the tracking issues #65490, #54883 for posterity.

This was referenced

Mar 8, 2020

Centril added a commit to Centril/rust that referenced this pull request

Mar 10, 2020