Stabilize Option::zip by tesuji · Pull Request #72938 · rust-lang/rust (original) (raw)
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
r? @cramertj
(rust_highfive has picked a reviewer for you, use r? to override)
Marks issues that should be documented in the release notes of the next release.
Relevant to the library API team, which will review and decide on the PR/issue.
labels
Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged team members:
No concerns currently listed.
Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
See this document for info about what commands tagged team members can give me.
| @@ -967,7 +969,7 @@ impl Option { |
|---|
| /// assert_eq!(x.zip_with(y, Point::new), Some(Point { x: 17.5, y: 42.7 })); |
| /// assert_eq!(x.zip_with(None, Point::new), None); |
| /// ``` |
| #[unstable(feature = "option_zip", issue = "70086")] |
| #[unstable(feature = "option_zip_with", issue = "70086")] |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we stabilize only a subset of a library feature, we change the name of the stabilized part, not the still unstable part. That way people only get unused feature warnings downstream, not build failures.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the stabilized feature to option_zip_option.
In the final comment period and will be merged soon unless new substantive objections are raised.
label
🔔 This is now entering its final comment period, as per the review above. 🔔
r=me with the feature names swapped around as @dtolnay mentioned
The final comment period, with a disposition to merge, as per the review above, is now complete.
As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.
The RFC will be merged soon.
In the final comment period and will be merged soon unless new substantive objections are raised.
label
📌 Commit 8b20928 has been approved by dtolnay
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
RalfJung added a commit to RalfJung/rust that referenced this pull request
This was referenced
Jun 15, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request
flip1995 pushed a commit to flip1995/rust that referenced this pull request
Either the GitHub milestone or the stability attribute is wrong. Former says 1.45.0, latter says 1.46.0.
Labels
This issue / PR is in PFCP or FCP with a disposition to merge it.
The final comment period is finished for this PR / Issue.
Marks issues that should be documented in the release notes of the next release.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the library API team, which will review and decide on the PR/issue.