Add explanation for &mut self method call when expecting -> Self by estebank · Pull Request #75613 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

If rustc_typeck had a diagnostics.rs, then I'd suggest to move it there, but unfortunately it doesn't.
@bors r+

📌 Commit ac73474 has been approved by petrochenkov

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Aug 17, 2020

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 18, 2020

Rollup of 8 pull requests

Successful merges:

• rust-lang#75389 (attempt to improve span_label docs)
• rust-lang#75392 (Add as_uninit-like methods to pointer types and unify documentation of as_ref methods)
• rust-lang#75464 (Move to intra doc links for ascii.rs and panic.rs)
• rust-lang#75578 (Allowing raw ptr dereference in const fn)
• rust-lang#75613 (Add explanation for &mut self method call when expecting -> Self)
• rust-lang#75626 (Clean up E0754 explanation)
• rust-lang#75629 (Use intra-doc links in std::env, std::alloc and std::error)
• rust-lang#75634 (Mark x86_64-linux-kernel as *)

Failed merges:

r? @ghost

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.