Switch to intra-doc links in core/src/{convert,iter}/mod.rs by nixphix · Pull Request #75969 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation27 Commits4 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Partial fix for #75080
@rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc
r? @jyn514
couldn't fix these
../../std/string/struct.String.html
../../std/primitive.never.html
../../std/sync/mpsc/struct.TryIter.html
Area: Intra-doc links, the ability to link to items in docs by name
Area: Documentation for any part of the project, including the compiler, standard library, and tools
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Relevant to the rustdoc team, which will review and decide on the PR/issue.
label
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's avoid repeating Iterator:: everywhere; it's pretty clear here that's what we're talking about and the Iterator docs are already pretty long.
error: `[i32::MAX]` cannot be resolved, ignoring it.
--> library/core/src/convert/mod.rs:413:40
|
413 | /// giving the [`i64`]'s value modulo [`i32::MAX`]) or by simply returning
| ^^^^^^^^^^ cannot be resolved, ignoring
Hmm ... This looks like either #74489 or #75649. If you wait for the beta bump today they should both be fixed.
Beta was bumped today, try rebasing and see if it fixes the CI failure?
@jyn514 tried rebasing twice still filing for the same reason, should I revert the change?
@jyn514 tried rebasing twice still filing for the same reason, should I revert the change?
I fixed the issue in #76093. You should revert the change in the meantime, since it will break with doc --stage 0 until the next release in 6 weeks.
bors added a commit to rust-lang-ci/rust that referenced this pull request
Fix intra-doc links for associated constants
Previously, only associated functions would be resolved. Fixes the issues in rust-lang#75969 (comment).
I'm a little uncomfortable hard-coding the string constants, but it looks like that's how it's done elsewhere. I might make a follow-up PR at some point putting it in one place.
Not sure how to test associated types, since AFAIK there aren't any on primitives.
r? @Manishearth
@jyn514 checks passed, I have set a reminder to fix this later
📌 Commit 7ea4c28 has been approved by jyn514
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
📌 Commit 523fea4 has been approved by jyn514
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request
Switch to intra-doc links in core/src/{convert,iter}/mod.rs
Partial fix for rust-lang#75080
@rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc
r? @jyn514
couldn't fix these
../../std/string/struct.String.html
../../std/primitive.never.html
../../std/sync/mpsc/struct.TryIter.htmlDylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request
Switch to intra-doc links in core/src/{convert,iter}/mod.rs
Partial fix for rust-lang#75080
@rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc
r? @jyn514
couldn't fix these
../../std/string/struct.String.html
../../std/primitive.never.html
../../std/sync/mpsc/struct.TryIter.htmlmatklad added a commit to matklad/rust that referenced this pull request
Switch to intra-doc links in core/src/{convert,iter}/mod.rs
Partial fix for rust-lang#75080
@rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc
r? @jyn514
couldn't fix these
../../std/string/struct.String.html
../../std/primitive.never.html
../../std/sync/mpsc/struct.TryIter.htmlThis was referenced
Aug 31, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request
Labels
Area: Documentation for any part of the project, including the compiler, standard library, and tools
Area: Intra-doc links, the ability to link to items in docs by name
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.