Stabilize IpAddr::is_ipv4 and is_ipv6 as const by CDirkx · Pull Request #76226 · rust-lang/rust (original) (raw)
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Insta-stabilize the methods is_ipv4 and is_ipv6 of std:🥅:IpAddr as const, in the same way as PR#76198.
Possible because of the recent stabilization of const control flow.
(rust_highfive has picked a reviewer for you, use r? to override)
This was referenced
Sep 2, 2020
This change is insta-stable, so needs a completed FCP to proceed.
label
Marks issues that should be documented in the release notes of the next release.
label
@rfcbot fcp merge
This is another set of constifying for boolean-style match methods. This time for IpAddr:
impl IpAddr { pub const fn is_ipv4(&self) -> bool; pub const fn is_ipv6(&self) -> bool; }
Team member @KodrAus has proposed to merge this. The next step is review by the rest of the tagged team members:
No concerns currently listed.
Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
See this document for info about what commands tagged team members can give me.
🔔 This is now entering its final comment period, as per the review above. 🔔
The final comment period, with a disposition to merge, as per the review above, is now complete.
As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.
The RFC will be merged soon.
📌 Commit b5746fe0b1f03b6a6e2f827165e38f7fa23b5295 has been approved by dtolnay
Status: Awaiting decision from the relevant subteam (see the T- label).
label
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Insta-stabilize the methods is_ipv4 and is_ipv6 of IpAddr.
Possible because of the recent stabilization of const control flow.
Also adds a test for these methods in a const context.
I bumped the version to 1.50.0
Good catch, thanks.
@bors r+
📌 Commit 4613bc9 has been approved by dtolnay
Area: Constant evaluation, covers all const contexts (static, const fn, ...)
label
Labels
Area: Constant evaluation, covers all const contexts (static, const fn, ...)
This issue / PR is in PFCP or FCP with a disposition to merge it.
The final comment period is finished for this PR / Issue.
This PR was explicitly merged by bors.
This change is insta-stable, so needs a completed FCP to proceed.
Marks issues that should be documented in the release notes of the next release.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the library API team, which will review and decide on the PR/issue.