Make delegation methods of std:🥅:IpAddr unstably const by CDirkx · Pull Request #76304 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation14 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Make the following methods of std:🥅:IpAddr unstable const under the const_ip feature:

• is_unspecified
• is_loopback
• is_global
• is_multicast

Also adds a test for these methods in a const context.

Possible because these methods delegate to the inner Ipv4Addr or Ipv6Addr, which were made const (PR#76205 and PR#76206), and the recent stabilization of const control flow.

Part of #76205

r? @ecstatic-morse

jyn514 changed the titleMake delegation methods of std:🥅:IpAddr const Make delegation methods of std:🥅:IpAddr unstably const

Sep 4, 2020

LGTM! Any reason not to do is_ipv{4,6} as part of this PR as well?

@bors delegate+

✌️ @CDirkx can now approve this pull request

I had already opened up PR#76226 to directly stabilize those as const, although I could include them here as unstable const, and when this gets merged rebase the stabilization PR.

📌 Commit 0c339b5bf283bfc839c06018190b2ab849be9270 has been approved by ecstatic-morse

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Sep 4, 2020

This was referenced

Sep 6, 2020

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 7, 2020

☔ The latest upstream changes (presumably #76422) made this pull request unmergeable. Please resolve the merge conflicts.

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Sep 7, 2020

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Sep 8, 2020

☔ The latest upstream changes (presumably #76850) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Sep 23, 2020

Huh, this seems to have never gotten added to the queue. bors retry can sometimes be finicky. Sorry @CDirkx. I'll make sure it gets in after a rebase.

Make the following methods of std:🥅:IpAddr unstable const under the const_ip feature:

• is_unspecified
• is_loopback
• is_global
• is_multicast

Also adds a test for these methods in a const context.

Possible because these methods delegate to the inner Ipv4Addr or Ipv6Addr, which were made const, and the recent stabilization of const control flow.

Part of rust-lang#76205

Ah, I thought I used the wrong command. Rebased, so @bors retry

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Sep 23, 2020

📌 Commit 947536f has been approved by ecstatic-morse

(I would use r={reviewer} when delegated to, retry seems to fail sometimes)

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request

Sep 24, 2020

Make delegation methods of std:🥅:IpAddr unstably const

Make the following methods of std:🥅:IpAddr unstable const under the const_ip feature:

• is_unspecified
• is_loopback
• is_global
• is_multicast

Also adds a test for these methods in a const context.

Possible because these methods delegate to the inner Ipv4Addr or Ipv6Addr, which were made const (PR#76205 and PR#76206), and the recent stabilization of const control flow.

Part of rust-lang#76205

r? @ecstatic-morse

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 25, 2020

RalfJung added the A-const-eval

Area: Constant evaluation, covers all const contexts (static, const fn, ...)

label

Dec 1, 2024

Labels

A-const-eval

Area: Constant evaluation, covers all const contexts (static, const fn, ...)

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-libs-api

Relevant to the library API team, which will review and decide on the PR/issue.