revert const_type_id stabilization by KodrAus · Pull Request #77083 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation17 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This reverts #72488, which is currently on beta and scheduled to stabilize in 1.47.0, based on #75923 (comment)
It turns out we might not be quite ready to stabilize TypeId in const contexts before having a chance to rework its internals. Since TypeId is a bit of an oddity we want to be careful about how those internals are currently being relied on while making changes. That will be easier to do without having to also consider compile-time contexts.
r? @eddyb
Relevant to the compiler team, which will review and decide on the PR/issue.
Area: Constant evaluation, covers all const contexts (static, const fn, ...)
labels
Accepted for beta backport (there's not really any point in landing this if we don't backport).
r=me, but also fine with waiting for @eddyb
@bors r=RalfJung p=1
I think we should get this landed and backported quickly.
📌 Commit 9b2c8d8 has been approved by RalfJung
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Thanks! Sorry I didn't see it earlier, but yeah it doesn't really need my review since it's just a backport.
I guess we can have the discussion on whether/when to re-land the stabilization elsewhere (perhaps a tracking issue?).
⌛ Testing commit 9b2c8d8 with merge 2eb3d29f7479ceef4dc61f4329c4d05c57b36f27...
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.
Click to expand the log.
##[group]Run exit 1
exit 1
shell: /bin/bash --noprofile --norc -e -o pipefail {0}
##[endgroup]
##[error]Process completed with exit code 1.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
I guess we can have the discussion on whether/when to re-land the stabilization elsewhere (perhaps a tracking issue?).
I actually would really like to use type ids in const contexts for what (I hope) are non-nefarious purposes 😄
We never actually had a proper tracking issue for this before and this PR currently links to type_name, so I'm creating a proper one for type_id now and will update the PR to point to that.
I've created a tracking issue: #77125
📌 Commit 0e2db57 has been approved by RalfJung
I think we should get this landed and backported quickly.
So who's doing the backport, are you or should someone else prepare a PR?
I will do a rollup after compiler meeting today, to catch anything else that gets approved.
bors added a commit to rust-lang-ci/rust that referenced this pull request
…ulacrum
[beta] backports
This backports the following:
- revert const_type_id stabilization rust-lang#77083
- [mir-opt] Disable the
ConsideredEquallogic in SimplifyBranchSame opt rust-lang#76837 - Rename Iterator::get_unchecked rust-lang#77201 (manually, because of file renaming and other issues on master causing literal cherry-pick to fail)
- Rebase LLVM onto 11.0.0-rc3 rust-lang#77063 (bumping direct to master, see rust-lang#77063 (comment)).
The last two have not yet been approved by compiler team, but I'm posting this now and going to go ahead and approve as I expect both to get approved and we want testing as much as possible before release in ~2 weeks.
r? @ghost
mbrubeck added a commit to mbrubeck/log that referenced this pull request
The const_type_id feature was planned to stabilize in Rust 1.47, but
this was reverted in: rust-lang/rust#77083
This causes errors when building log with the kv_unstable feature on
Rust 1.47 or later. This patch removes the use of this no-longer-stable
feature in those Rust versions.
Labels
Area: Constant evaluation, covers all const contexts (static, const fn, ...)
Accepted for backporting to the compiler in the beta channel.
This PR was explicitly merged by bors.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.