Stabilize `const_panic` by jhpratt · Pull Request #89508 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation9 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Closes #51999

FCP completed in #89006

@rustbot label +A-const-eval +A-const-fn +T-lang

cc @oli-obk for review (not r?'ing as not on lang team)

stepancheg and toku-sa-n reacted with thumbs up emoji oli-obk, RalfJung, slanterns, raftario, nbdd0121, Aaron1011, yvt, camelid, crawford, therealprof, and 14 more reacted with hooray emoji

rustbot added the T-lang

Relevant to the language team, which will review and decide on the PR/issue.

label

Oct 4, 2021

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

This comment has been minimized.

Since the FCP has already completed, r=me when CI passes.

Sounds good.

@rustbot label -S-waiting-on-review +S-waiting-on-author

rustbot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Oct 4, 2021

joshtriplett added the relnotes

Marks issues that should be documented in the release notes of the next release.

label

Oct 4, 2021

@jhpratt: 🔑 Insufficient privileges: Not in reviewers

📌 Commit bce8621 has been approved by joshtriplett

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Oct 4, 2021

Manishearth added a commit to Manishearth/rust that referenced this pull request

Oct 4, 2021

…shtriplett

Stabilize const_panic

Closes rust-lang#51999

FCP completed in rust-lang#89006

@rustbot label +A-const-eval +A-const-fn +T-lang

cc @oli-obk for review (not r?'ing as not on lang team)

Manishearth added a commit to Manishearth/rust that referenced this pull request

Oct 4, 2021

…shtriplett

Stabilize const_panic

Closes rust-lang#51999

FCP completed in rust-lang#89006

@rustbot label +A-const-eval +A-const-fn +T-lang

cc @oli-obk for review (not r?'ing as not on lang team)

bors added a commit to rust-lang-ci/rust that referenced this pull request

Oct 4, 2021

…ingjubilee

Rollup of 13 pull requests

Successful merges:

rust-lang#83655 ([aarch64] add target feature outline-atomics)
rust-lang#87091 (implement advance_(back_)_by on more iterators)
rust-lang#88451 (Fix an ICE caused by type mismatch errors being ignored)
rust-lang#88452 (VecDeque: improve performance for From<[T; N]>)
rust-lang#89400 (Improve wording of map_or_else docs)
rust-lang#89407 (Recommend running cargo clean in E0514 output)
rust-lang#89443 (Include the length in BTree hashes)
rust-lang#89444 (rustdoc: use slice::contains instead of open-coding it)
rust-lang#89447 (Improve error message for missing angle brackets in [_]::method)
rust-lang#89453 (Consistently use 'supertrait'.)
rust-lang#89483 (Practice diagnostic message convention)
rust-lang#89500 (Fix ICE with buffered lint referring to AST node deleted by everybody_loops)
rust-lang#89508 (Stabilize const_panic)

Failed merges:

r? @ghost @rustbot modify labels: rollup

jhpratt deleted the stabilize-const_panic branch

October 5, 2021 00:25

Thomasdezeeuw added a commit to Thomasdezeeuw/heph that referenced this pull request

Oct 9, 2021

Thomasdezeeuw added a commit to Thomasdezeeuw/heph that referenced this pull request

Oct 9, 2021

JohnTitor added a commit to JohnTitor/rust that referenced this pull request

Oct 15, 2021

…_unchecked, r=oli-obk

Stabilize unreachable_unchecked as const fn

Closes rust-lang#53188

This PR stabilizes core::hint::unreachable_unchecked as const fn. MIRI is able to detect when this method is called. Stabilization was delayed until const_panic was stabilized so as to avoid users calling this method in its place (thus resulting in runtime UB). With rust-lang#89508, that is no longer an issue.

@rustbot label +A-const-eval +A-const-fn +T-lang +S-blocked

(not sure why it's T-lang, but that's what the tracking issue is)

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Oct 15, 2021