Add From for ExitCode by yaahc · Pull Request #93445 · rust-lang/rust (original) (raw)

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

This comment has been minimized.

joshtriplett added the T-libs-api

Relevant to the library API team, which will review and decide on the PR/issue.

label

Jan 29, 2022

Trait impls are insta-stable, and even though ExitCode isn't stable, it might be possible for stable code to write something like From::from and potentially depend on this indirectly. So, to be safe, I think this should go through an FCP:

@rfcbot merge

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

🔔 This is now entering its final comment period, as per the review above. 🔔

This should cover a mostly cross-platform subset of supported exit codes.

Rebased to resolve conflict with Change Termination::report return type to ExitCode #93442 in library/std/src/process.rs

📌 Commit cf4ac6b has been approved by dtolnay

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Feb 6, 2022

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 6, 2022

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 7, 2022

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 7, 2022

This failed in #93734:

169 |             1..255 => Self::FAILURE,
    |             ^^^^^^
    |
    = note: see issue #37854 <https://github.com/rust-lang/rust/issues/37854> for more information
    = help: add `#![feature(exclusive_range_pattern)]` to the crate attributes to enable
For more information about this error, try `rustc --explain E0658`.
[RUSTC-TIMING] std test:false 1.657
warning: `std` (lib) generated 1 warning
error: could not compile `std` due to previous error; 1 warning emitted

@bors r-

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Feb 7, 2022

📌 Commit 4c5a36e has been approved by dtolnay

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Feb 7, 2022

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 9, 2022

Rollup of 7 pull requests

Successful merges:

rust-lang#93445 (Add From for ExitCode)
rust-lang#93694 (rustdoc: tweak line spacing and paragraph spacing for accessibility)
rust-lang#93735 (Stabilize int_abs_diff in 1.60.0.)
rust-lang#93746 (Remove defaultness from ImplItem.)
rust-lang#93748 (rustc_query_impl: reduce visibility of some modules/fn's)
rust-lang#93751 (Drop tracking: track borrows of projections)
rust-lang#93781 (update ty::TyKind documentation)

Failed merges:

r? @ghost @rustbot modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Sep 19, 2024

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Sep 19, 2024

Labels

disposition-merge

This issue / PR is in PFCP or FCP with a disposition to merge it.

finished-final-comment-period

The final comment period is finished for this PR / Issue.

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-libs-api

Relevant to the library API team, which will review and decide on the PR/issue.