Implement --check-cfg option (RFC 3013), take 2 by Urgau · Pull Request #93915 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation36 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This pull-request implement RFC 3013: Checking conditional compilation at compile time (rust-lang/rfcs#3013) and is based on the previous attempt #89346 by @mwkmwkmwk that was closed due to inactivity.
I have address all the review comments from the previous attempt and added some more tests.
cc #82450
r? @petrochenkov
Relevant to the compiler team, which will review and decide on the PR/issue.
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
I have address all the review comments and added tests for the uncovered error cases.
I believe this is now ready for another review.
@rustbot ready
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
This comment has been minimized.
I have fix the last review comments (except for to_check_config, for which I put a comment).
I believe this is now ready for another review.
@rustbot ready
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Status: Awaiting review from the assignee but also interested parties.
labels
Co-authored-by: Urgau lolo.branstett@numericable.fr Co-authored-by: Marcelina Kościelnicka mwk@0x04.net
r=me after addressing #93915 (comment) and squashing commits.
Addressed and squashed, but I don't have bors permissions so I can't r=you.
@rustbot ready
Status: This is awaiting some action (such as code changes or more information) from the author.
label
📌 Commit 3a73ca5 has been approved by petrochenkov
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
…askrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#89892 (Suggest
impl Traitreturn type when incorrectly using a generic return type) - rust-lang#91675 (Add MemTagSanitizer Support)
- rust-lang#92806 (Add more information to
impl Traiterror) - rust-lang#93497 (Pass
--testflag through rustdoc to rustc so#[test]functions can be scraped) - rust-lang#93814 (mips64-openwrt-linux-musl: correct soft-foat)
- rust-lang#93847 (kmc-solid: Use the filesystem thread-safety wrapper)
- rust-lang#93877 (asm: Allow the use of r8-r14 as clobbers on Thumb1)
- rust-lang#93892 (Only mark projection as ambiguous if GAT substs are constrained)
- rust-lang#93915 (Implement --check-cfg option (RFC 3013), take 2)
- rust-lang#93953 (Add the
known-bugtest directive, use it, and do some cleanup)
Failed merges:
r? @ghost
@rustbot modify labels: rollup
This was referenced
Feb 19, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…eGomez
Wire up unstable rustc --check-cfg to rustdoc
This pull-request wire up the new unstable --check-cfg option from rustc to rustdoc as [requested](rust-lang#93915 (comment)) in the pull-request that introduce --check-cfg.
The motivation was describe in the original PR by @jyn514 who wrote rust-lang#89346 (comment):
add plumbing to pass --check-cfg from rustdoc (do we want this one?)
It would be useful, I think, it catches issues like cfg(doctst) or something (and in general I would like expansion to match rustc as closely as possible).
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…eGomez
Wire up unstable rustc --check-cfg to rustdoc
This pull-request wire up the new unstable --check-cfg option from rustc to rustdoc as [requested](rust-lang#93915 (comment)) in the pull-request that introduce --check-cfg.
The motivation was describe in the original PR by @jyn514 who wrote rust-lang#89346 (comment):
add plumbing to pass --check-cfg from rustdoc (do we want this one?)
It would be useful, I think, it catches issues like cfg(doctst) or something (and in general I would like expansion to match rustc as closely as possible).
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.