Use Metadata::modified instead of FileTime::from_last_modification_ti… by bjorn3 · Pull Request #94190 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
…me in run_cargo
Metadata::modified works in all platforms supported by the filetime
crate. This changes brings rustbuild a tiny bit closer towards dropping
the filetime dependency.
…me in run_cargo
Metadata::modified works in all platforms supported by the filetime crate. This changes brings rustbuild a tiny bit closer towards dropping the filetime dependency.
Category: PRs that clean code up or issues documenting cleanup.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
(rust-highfive has picked a reviewer for you, use r? to override)
📌 Commit b45cb09 has been approved by Mark-Simulacrum
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…crum
Use Metadata::modified instead of FileTime::from_last_modification_ti…
…me in run_cargo
Metadata::modified works in all platforms supported by the filetime crate. This changes brings rustbuild a tiny bit closer towards dropping the filetime dependency.
Manishearth added a commit to Manishearth/rust that referenced this pull request
…crum
Use Metadata::modified instead of FileTime::from_last_modification_ti…
…me in run_cargo
Metadata::modified works in all platforms supported by the filetime crate. This changes brings rustbuild a tiny bit closer towards dropping the filetime dependency.
Manishearth added a commit to Manishearth/rust that referenced this pull request
…crum
Use Metadata::modified instead of FileTime::from_last_modification_ti…
…me in run_cargo
Metadata::modified works in all platforms supported by the filetime crate. This changes brings rustbuild a tiny bit closer towards dropping the filetime dependency.
bors added a commit to rust-lang-ci/rust that referenced this pull request
…askrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#91192 (Some improvements to the async docs)
- rust-lang#94143 (rustc_const_eval: adopt let else in more places)
- rust-lang#94156 (Gracefully handle non-UTF-8 string slices when pretty printing)
- rust-lang#94186 (Update pin_static_ref stabilization version.)
- rust-lang#94189 (Implement LowerHex on Scalar to clean up their display in rustdoc)
- rust-lang#94190 (Use Metadata::modified instead of FileTime::from_last_modification_ti…)
- rust-lang#94203 (CTFE engine: Scalar: expose size-generic to_(u)int methods)
- rust-lang#94211 (Better error if the user tries to do assignment ... else)
- rust-lang#94215 (trait system: comments and small nonfunctional changes)
- rust-lang#94220 (Correctly handle miniz_oxide extern crate declaration)
Failed merges:
r? @ghost
@rustbot modify labels: rollup
Labels
Category: PRs that clean code up or issues documenting cleanup.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)