rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Should fix #96163. Can't easily test on Windows though...

rustbot added the T-libs

Relevant to the library team, which will review and decide on the PR/issue.

label

Apr 18, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

This looks fine to me, and I have familiarity with the area (having rewrote several of these functions before). https://std-dev-guide.rust-lang.org/reviewing.html indicates that I can just r+ it. I am assuming if the assigned reviewer wanted to review it, they'd have gotten to it by now, hopefully this is not out of line.

This also is an annoying issue because it causes HashMap not to be usable in miri (under certain settings) on macOS, so it would be good to fix (e.g. I'd personally like it fixed).

@bors r+

📌 Commit 620c0a4 has been approved by thomcc

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Apr 19, 2022

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request

Apr 20, 2022

…thomcc

Replace sys/unix/weak AtomicUsize with AtomicPtr

Should fix rust-lang#96163. Can't easily test on Windows though...

bors added a commit to rust-lang-ci/rust that referenced this pull request

Apr 20, 2022

Rollup of 6 pull requests

Successful merges:

rust-lang#93313 (Check if call return type is visibly uninhabited when building MIR)
rust-lang#96160 (Miri/interpreter debugging tweaks)
rust-lang#96167 (Replace sys/unix/weak AtomicUsize with AtomicPtr)
rust-lang#96168 (Improve AddrParseError description)
rust-lang#96206 (Use sys::unix::locks::futex* on wasm+atomics.)
rust-lang#96234 (remove_dir_all_recursive: treat ELOOP the same as ENOTDIR)

Failed merges:

r? @ghost @rustbot modify labels: rollup

CAD97 deleted the weak-dlsym-less-ptr-crime branch

April 20, 2022 21:06

nvzqz mentioned this pull request

Jun 6, 2022

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.