Stabilize `const_ptr_offset_from`. by fee1-dead · Pull Request #96240 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation24 Commits2 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Stabilization has been completed here with a FCP.

Closes #92980.

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

rustbot added the T-libs

Relevant to the library team, which will review and decide on the PR/issue.

label

Apr 20, 2022

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

r? rust-lang/libs-api

@rustbot label +T-libs-api +T-lang -T-libs

rustbot added T-lang

Relevant to the language team, which will review and decide on the PR/issue.

T-libs-api

Relevant to the library API team, which will review and decide on the PR/issue.

labels

Apr 20, 2022

rustbot removed the T-libs

Relevant to the library team, which will review and decide on the PR/issue.

label

Apr 20, 2022

This comment has been minimized.

ojeda mentioned this pull request

Apr 21, 2022

95 tasks

This comment has been minimized.

Is there an update for this?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than bumping the version to 1.63, LGTM.

fee1-dead added the relnotes

Marks issues that should be documented in the release notes of the next release.

label

Jun 4, 2022

@@ -1903,11 +1903,11 @@ extern "rust-intrinsic" {
pub fn nontemporal_store(ptr: *mut T, val: T);

/// See documentation of `<*const T>::offset_from` for details.
#[rustc_const_unstable(feature = "const_ptr_offset_from", issue = "92980")]
#[rustc_const_stable(feature = "const_ptr_offset_from", since = "1.63.0")]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.64.0 here and lower?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

Sorry to bump this again, but I think this stabilization is super exciting and important, since it finally allows for const offsetof(Foo.bar) calculations. I think by this point it should be stable since = "1.65.0" since 1.63 has been released, but could someone from the libs-api team (@jhpratt?) take a look at it after? The FCP was completed 5+ months ago at this point.

I'm not on T-libs-api, but I'll take another look at it in the near future.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with before, diff LGTM. Just needs the version bumped to 1.65, naturally.

This comment has been minimized.

📌 Commit 69ad634 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Aug 27, 2022

compiler-errors added a commit to compiler-errors/rust that referenced this pull request

Aug 27, 2022

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 27, 2022

Rollup of 11 pull requests

Successful merges:

rust-lang#96240 (Stabilize const_ptr_offset_from.)
rust-lang#99784 (Make forward compatibility lint deprecated_cfg_attr_crate_type_name deny by default)
rust-lang#100811 (Fix wrong compiletest filters on Windows)
rust-lang#100924 (Smaller improvements of tidy and the unicode generator)
rust-lang#100953 (Update documentation for write! and writeln!)
rust-lang#101018 (rustdoc: omit start/end tags for empty item description blocks)
rust-lang#101044 (rustdoc: remove unused CSS for hidden-by-*-hider)
rust-lang#101046 (rustdoc: remove incorrect CSS selector .impl-items table td)
rust-lang#101057 (Merge implementations of HIR fn_decl and fn_sig.)
rust-lang#101062 (rustdoc: remove empty extern_crates and type="text/javascript" on script)
rust-lang#101063 (Merge duplicated CSS rules)