Some more EarlyBinder cleanups by jackh726 · Pull Request #99038 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation6 Commits4 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
First commit has a couple unrelated cleanups, but otherwise each commit is self-explanatory
r? rust-lang/types
Relevant to the compiler team, which will review and decide on the PR/issue.
label
Some changes occurred to MIR optimizations
cc @rust-lang/wg-mir-opt
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me after dealing with my comment in any way you see fit
| @@ -1812,8 +1810,11 @@ impl<'a, 'tcx> ProbeContext<'a, 'tcx> { |
|---|
| } |
| /// Gets the type of an impl and generate substitutions with placeholders. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| /// Gets the type of an impl and generate substitutions with placeholders. |
|---|
| /// Gets the type of an impl and generate substitutions with inference vars. |
though really, impl_ty_and_substs should be replaced with a function which just eagerly calls subst.
📌 Commit 988e754 has been approved by lcnr
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request
Some more EarlyBinder cleanups
First commit has a couple unrelated cleanups, but otherwise each commit is self-explanatory
r? rust-lang/types
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request
Some more EarlyBinder cleanups
First commit has a couple unrelated cleanups, but otherwise each commit is self-explanatory
r? rust-lang/types
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request
Some more EarlyBinder cleanups
First commit has a couple unrelated cleanups, but otherwise each commit is self-explanatory
r? rust-lang/types
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 6 pull requests
Successful merges:
- rust-lang#98622 (rustc_target: Flip the default for
TargetOptions::executablesto true) - rust-lang#98633 (Fix last
let_chainsblocker) - rust-lang#98972 (Suggest adding a missing zero to a floating point number)
- rust-lang#99038 (Some more
EarlyBindercleanups) - rust-lang#99154 (use PlaceRef::iter_projections to fix old FIXME)
- rust-lang#99171 (Put back UI test regex)
Failed merges:
r? @ghost
@rustbot modify labels: rollup
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.