Add Read Impl for &Stdin by Dajamante · Pull Request #99153 · rust-lang/rust (original) (raw)

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon.

Please see the contribution instructions for more information.

rustbot added T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.

labels

Jul 11, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

rustbot added T-libs-api

Relevant to the library API team, which will review and decide on the PR/issue.

and removed T-libs

Relevant to the library team, which will review and decide on the PR/issue.

labels

Jul 11, 2022

triage:
@m-ou-se this has sat since July - can you post the status of the review?

Noratrieb removed the T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

label

Dec 27, 2022

@@ -437,6 +437,28 @@ impl Read for Stdin {
}
}

#[stable(feature = "rust1", since = "1.0.0")]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please choose some other unique feature name and set the stabilization version to "CURRENT_RUSTC_VERSION".

dtolnay added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-ACP

Status: PR has an ACP and is waiting for the ACP to complete.

labels

Feb 23, 2024

dtolnay added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Feb 26, 2024

I filled in a feature name to resolve #99153 (review), and an implementation of Read::read_buf which was added in impl Read for Stdin by #108326 after this PR was originally opened.