Mention rust-analyzer maintainers when proc_macro bridge is changed by jonas-schievink · Pull Request #99183 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
rust-analyzer vendors a modified copy of the proc_macro crate in order to expand procedural macros built by Cargo. Since the ABI used by proc macros can change, we need to follow along with those changes. Getting notified when the proc macro bridge changes should make that easier, since that's what defines the ABI.
cc @rust-lang/wg-rls-2
(rust-highfive has picked a reviewer for you, use r? to override)
@bors r+ rollup
btw, are we planning to keep the team name "wg-rls-2" indefinitely? I would expect it to change to wg-rls or wg-rust-analyzer at some point.
📌 Commit 2f0172f has been approved by jyn514
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request
…r-a, r=jyn514
Mention rust-analyzer maintainers when proc_macro bridge is changed
rust-analyzer vendors a modified copy of the proc_macro crate in order to expand procedural macros built by Cargo. Since the ABI used by proc macros can change, we need to follow along with those changes. Getting notified when the proc macro bridge changes should make that easier, since that's what defines the ABI.
cc @rust-lang/wg-rls-2
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request
…r-a, r=jyn514
Mention rust-analyzer maintainers when proc_macro bridge is changed
rust-analyzer vendors a modified copy of the proc_macro crate in order to expand procedural macros built by Cargo. Since the ABI used by proc macros can change, we need to follow along with those changes. Getting notified when the proc macro bridge changes should make that easier, since that's what defines the ABI.
cc @rust-lang/wg-rls-2
bors added a commit to rust-lang-ci/rust that referenced this pull request
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…mention-r-a, r=Mark-Simulacrum
Revert "Mention rust-analyzer maintainers when proc_macro bridge is changed"
Reverts rust-lang#99183
rust-analyzer is now a subtree, and CI fails when the proc_macro bridge changes break our tests, so these notifications aren't needed anymore.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request
…mention-r-a, r=Mark-Simulacrum
Revert "Mention rust-analyzer maintainers when proc_macro bridge is changed"
Reverts rust-lang#99183
rust-analyzer is now a subtree, and CI fails when the proc_macro bridge changes break our tests, so these notifications aren't needed anymore.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request
…mention-r-a, r=Mark-Simulacrum
Revert "Mention rust-analyzer maintainers when proc_macro bridge is changed"
Reverts rust-lang#99183
rust-analyzer is now a subtree, and CI fails when the proc_macro bridge changes break our tests, so these notifications aren't needed anymore.
Labels
Area: Issues & PRs about the rust-lang/rust repository itself
Area: Procedural macros
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.