Disable cfg check for the recently-merged target features to allow stdarch update by sayantn · Pull Request #1768 · rust-lang/stdarch (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation5 Commits1 Checks60 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
The stdarch update is currently giving doc errors, which #1767 fixes. But then it will give unknown cfg errors due to the recently added amx and riscv target features, so this pr temporarily disables those checks. Revert after the bump is successful
r? @Amanieu
rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@sayantn
I'd like to ask how do we know that unknown cfg errors are fixed (and/or which CI failures to track) to know the right timing to revert this PR.
Just making documentation seems working on my local environment so I think there is a failing configuration.
These unknown cfg errors are obtained when stdarch is built as a part of libstd, by itself stdarch should compile fine - the bootstrapping architecture of rustc creates the problem because the stage0 compiler doesn't yet know about those new target features.
It should be good to revert once a stdarch update gets merged, or the bootstrap version gets bumped
It should be good to revert once a stdarch update gets merged, or the bootstrap version gets bumped
I think this could be handled by the special bootstrap cfg set by the rust-lang/rust build-system.
afaik this repo doesn't use cfg(bootstrap) because the update cfgs commit (which removes all cfg(bootstrap) items after the bootstrap bump) wouldn't work here because this is still a submodule, not a subtree. Using cfg(bootstrap) here will require a PR here after bootstrap bump, and a stdarch submodule update in rustc, which might create a lot of problems, because stdarch updates are typically problematic as stdarch CI and rustc CI don't match perfectly
bors added a commit to rust-lang-ci/rust that referenced this pull request
…nieu
Update stdarch submodule
rust-lang/stdarch#1768 is needed to unblock the cg_gcc current sync so this PR updates the stdarch submodule.
cc @antoyo
r? @Amanieu
