Fix_stft_istft_window_parameters by faroit · Pull Request #107 · sigsep/open-unmix-pytorch (original) (raw)

Skip to content

Sign in

Appearance settings

View all features

View all solutions

View all resources

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

sigsep / open-unmix-pytorch Public

Additional navigation options

Merged

faroit merged 2 commits intomasterfrom

fix_stft_istft_window_parameters

Sep 20, 2021

ConversationCommits (2)ChecksFiles changed

Merged

Fix_stft_istft_window_parameters#107

faroit merged 2 commits intomasterfrom

fix_stft_istft_window_parameters

Conversation

@faroit

Copy link Copy Markdown

Member

@faroit faroit commented

Sep 20, 2021

No description provided.

faroit added 2 commits

September 20, 2021 10:44

@faroit

[add more types](/sigsep/open-unmix-pytorch/pull/107/commits/b3ca0ec362ddb19c1d704062f099ff83c25fcdf5 "add more types")

[b3ca0ec](/sigsep/open-unmix-pytorch/pull/107/commits/b3ca0ec362ddb19c1d704062f099ff83c25fcdf5)

@faroit

[fix filterbank error when no window is passed](/sigsep/open-unmix-pytorch/pull/107/commits/be46ae73135d965509bc9034aadff70cebf2de93 "fix filterbank error when no window is passed")

[be46ae7](/sigsep/open-unmix-pytorch/pull/107/commits/be46ae73135d965509bc9034aadff70cebf2de93)

@codecov

Copy link Copy Markdown

codecov bot commented

Sep 20, 2021

edited

Loading

Codecov Report

Merging #107 (be46ae7) into master (11ef178) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #107 +/- ##

Impacted Files Coverage Δ
openunmix/model.py 87.90% <100.00%> (+0.09%) ⬆️
openunmix/transforms.py 93.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11ef178...be46ae7. Read the comment docs.

@faroit faroit merged commit 49e65ac into master

Sep 20, 2021

@faroit faroit deleted the fix_stft_istft_window_parameters branch

September 20, 2021 09:02

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@faroit