Fix_stft_istft_window_parameters by faroit · Pull Request #107 · sigsep/open-unmix-pytorch (original) (raw)
Navigation Menu
Appearance settings
- AI CODE CREATION
* GitHub CopilotWrite better code with AI
* GitHub SparkBuild and deploy intelligent apps
* GitHub ModelsManage and compare prompts
* MCP RegistryNewIntegrate external tools - DEVELOPER WORKFLOWS
* ActionsAutomate any workflow
* CodespacesInstant dev environments
* IssuesPlan and track work
* Code ReviewManage code changes - APPLICATION SECURITY
* GitHub Advanced SecurityFind and fix vulnerabilities
* Code securitySecure your code as you build
* Secret protectionStop leaks before they start - EXPLORE
* Why GitHub
* Documentation
* Blog
* Changelog
* Marketplace
- AI CODE CREATION
- BY COMPANY SIZE
* Enterprises
* Small and medium teams
* Startups
* Nonprofits - BY USE CASE
* App Modernization
* DevSecOps
* DevOps
* CI/CD
* View all use cases - BY INDUSTRY
* Healthcare
* Financial services
* Manufacturing
* Government
* View all industries
- BY COMPANY SIZE
- EXPLORE BY TOPIC
* AI
* Software Development
* DevOps
* Security
* View all topics - EXPLORE BY TYPE
* Customer stories
* Events & webinars
* Ebooks & reports
* Business insights
* GitHub Skills - SUPPORT & SERVICES
* Documentation
* Customer support
* Community forum
* Trust center
* Partners
- EXPLORE BY TOPIC
- COMMUNITY
* GitHub SponsorsFund open source developers - PROGRAMS
* Security Lab
* Maintainer Community
* Accelerator
* GitHub Stars
* Archive Program - REPOSITORIES
* Topics
* Trending
* Collections
- COMMUNITY
- Pricing
Provide feedback
We read every piece of feedback, and take your input very seriously.
Include my email address so I can be contacted
Saved searches
Use saved searches to filter your results more quickly
Appearance settings
sigsep / open-unmix-pytorch Public
Notifications You must be signed in to change notification settings
Additional navigation options
Merged
faroit merged 2 commits intomasterfrom
fix_stft_istft_window_parameters
Sep 20, 2021
ConversationCommits (2)ChecksFiles changed
Merged
Fix_stft_istft_window_parameters#107
faroit merged 2 commits intomasterfrom
fix_stft_istft_window_parameters
Conversation
Copy link Copy Markdown
Member
faroit commented
No description provided.
faroit added 2 commits
[add more types](/sigsep/open-unmix-pytorch/pull/107/commits/b3ca0ec362ddb19c1d704062f099ff83c25fcdf5 "add more types")
[b3ca0ec](/sigsep/open-unmix-pytorch/pull/107/commits/b3ca0ec362ddb19c1d704062f099ff83c25fcdf5)
[fix filterbank error when no window is passed](/sigsep/open-unmix-pytorch/pull/107/commits/be46ae73135d965509bc9034aadff70cebf2de93 "fix filterbank error when no window is passed")
[be46ae7](/sigsep/open-unmix-pytorch/pull/107/commits/be46ae73135d965509bc9034aadff70cebf2de93)
Copy link Copy Markdown
codecov bot commented
•
edited
Loading
Codecov Report
Merging #107 (be46ae7) into master (11ef178) will increase coverage by
0.01%.
The diff coverage is100.00%.
@@ Coverage Diff @@ ## master #107 +/- ##
Coverage 77.01% 77.03% +0.01%
Files 18 18
Lines 1327 1328 +1- Hits 1022 1023 +1
Misses 305 305
| Impacted Files | Coverage Δ | |
|---|---|---|
| openunmix/model.py | 87.90% <100.00%> (+0.09%) | ⬆️ |
| openunmix/transforms.py | 93.58% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 11ef178...be46ae7. Read the comment docs.
faroit merged commit 49e65ac into master
faroit deleted the fix_stft_istft_window_parameters branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.