Deprecate Parser.{config,env} by AA-Turner · Pull Request #13644 · sphinx-doc/sphinx (original) (raw)

Skip to content

Navigation Menu

Sign in

Appearance settings

• • AI CODE CREATION
    * GitHub CopilotWrite better code with AI
    * GitHub SparkBuild and deploy intelligent apps
    * GitHub ModelsManage and compare prompts
    * MCP RegistryNewIntegrate external tools
  • DEVELOPER WORKFLOWS
    * ActionsAutomate any workflow
    * CodespacesInstant dev environments
    * IssuesPlan and track work
    * Code ReviewManage code changes
  • APPLICATION SECURITY
    * GitHub Advanced SecurityFind and fix vulnerabilities
    * Code securitySecure your code as you build
    * Secret protectionStop leaks before they start
  • EXPLORE
    * Why GitHub
    * Documentation
    * Blog
    * Changelog
    * Marketplace

View all features

• • BY COMPANY SIZE
    * Enterprises
    * Small and medium teams
    * Startups
    * Nonprofits
  • BY USE CASE
    * App Modernization
    * DevSecOps
    * DevOps
    * CI/CD
    * View all use cases
  • BY INDUSTRY
    * Healthcare
    * Financial services
    * Manufacturing
    * Government
    * View all industries

View all solutions

• • EXPLORE BY TOPIC
    * AI
    * Software Development
    * DevOps
    * Security
    * View all topics
  • EXPLORE BY TYPE
    * Customer stories
    * Events & webinars
    * Ebooks & reports
    * Business insights
    * GitHub Skills
  • SUPPORT & SERVICES
    * Documentation
    * Customer support
    * Community forum
    * Trust center
    * Partners

View all resources

• • COMMUNITY
    * GitHub SponsorsFund open source developers
  • PROGRAMS
    * Security Lab
    * Maintainer Community
    * Accelerator
    * GitHub Stars
    * Archive Program
  • REPOSITORIES
    * Topics
    * Trending
    * Collections
• • ENTERPRISE SOLUTIONS
    * Enterprise platformAI-powered developer platform
  • AVAILABLE ADD-ONS
    * GitHub Advanced SecurityEnterprise-grade security features
    * Copilot for BusinessEnterprise-grade AI features
    * Premium SupportEnterprise-grade 24/7 support
• Pricing

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

sphinx-doc / sphinx Public

• Notifications You must be signed in to change notification settings

• Fork2.4k

• Star 7.8k

• Code

• Issues 1.3k

• Pull requests 153

• Discussions

• Actions

• Projects

• Security and quality

• Insights

Additional navigation options

Merged

AA-Turner merged 1 commit intosphinx-doc:masterfrom

AA-Turner:cleanup/deprecate-parser-objs

Jun 10, 2025

ConversationCommits (1)ChecksFiles changed

Merged

Deprecate Parser.{config,env}#13644

AA-Turner merged 1 commit intosphinx-doc:masterfrom

AA-Turner:cleanup/deprecate-parser-objs

Conversation

Copy link Copy Markdown

Member

AA-Turner commented

Jun 10, 2025

It's unclear if these attributes are used in third-party projects, and removing them would allow for a great deal of simplification. I'm open to reversing this deprecation if the impact is too large.

A

[Deprecate Parser.{config,env}](/sphinx-doc/sphinx/pull/13644/commits/bca40713156f3cff4ab38868b0105757fe6396c9 "Deprecate ``Parser.{config,env}``")

[bca4071](/sphinx-doc/sphinx/pull/13644/commits/bca40713156f3cff4ab38868b0105757fe6396c9)

AA-Turner added the internals:refactoring label

Jun 10, 2025

AA-Turner merged commit bb5e545 into sphinx-doc:master

Jun 10, 2025

25 checks passed

AA-Turner deleted the cleanup/deprecate-parser-objs branch

June 10, 2025 00:50

Copy link Copy Markdown

Contributor

bsipocz commented

Jul 2, 2025

This triggered in our CI for MyST-NB, I'm looking into the code now if we in fact use them or just inherited and propagated down the line.

https://github.com/executablebooks/MyST-NB/actions/workflows/tests_devdeps.yml

Copy link Copy Markdown

Contributor

bsipocz commented

Jul 3, 2025

Indeed, we are using env in our parser class https://github.com/executablebooks/MyST-NB/blob/master/myst_nb/sphinx_.py#L56 as well as through the Myst-parser lib (https://github.com/executablebooks/MyST-Parser).

It's not trivially clear how difficult it would be to work around these deprecation, and to judge the impact, but I would say there are quite a lot of projects out there that uses MyST-NB for their rendering; a handful of them are listed here: https://executablebooks.org/en/latest/gallery/ but also some libraries such as scipy now relies of MyST-NB for their library documentation build: https://github.com/scipy/scipy/blob/main/pyproject.toml#L99

bsipocz mentioned this pull request

Jul 3, 2025

COMPability: devdeps job is failing with RemovedInSphinx90Warningexecutablebooks/MyST-NB#681

Closed

AA-Turner mentioned this pull request

Jul 7, 2025

KeyError: 'writer' with myST-Parser since PR #13676#13713

Closed

github-actions bot locked as resolved and limited conversation to collaborators

Aug 1, 2025

AA-Turner added this to the 9.0.0 milestone

Nov 25, 2025

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

internals:refactoring

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

2 participants