Port Funky Gases by CrazyPhantom779 · Pull Request #2983 · ss14Starlight/space-station-14 (original) (raw)
Merge pull request #14 from marc-pelletier/funky-gases Fork Funky Gases
Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved.
label
Status: Reviewed and approved by at least one maintainer or dev; a PR may require another approval.
and removed S: Needs Review
Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved.
labels
Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved.
label
Rinary1 added a commit that referenced this pull request
Short description
Ports the following PR's from Carpmosia (MIT) For 5 Pipe layers carpmosia/carpmosia#44 carpmosia/carpmosia#68 carpmosia/carpmosia#70 carpmosia/carpmosia#87 carpmosia/carpmosia#126 Pipe file cleanup from carpmosia/carpmosia#208 carpmosia/carpmosia#250
Why we need to add this
3 Pipe layers aren't very good for high tier Atmos and 5 layers just gives more freedom overall with (AFAIK) little to no performance impact.
As well as the fact that following #2983 which adds a whopping 10 gases and likely some more to follow we just dont have enough room for atmos to have fun with them all.
Media (Video/Screenshots)
TO-DO
- Guidebook?
- Likely change sprites to 4 pixels wide or give more room between the current sprites
Checks
- I do not require assistance to complete the PR.
- Before posting/requesting review of a PR, I have verified that the changes work.
- I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
- I affirm that my changes are licensed under the Starlight Fork License and grant permission for use in this repository under its conditions.
Changelog
🆑 CrazyPhantom
- add: Quaternary and Quinary Pipe layers for a total of 5 layers.
- tweak: Makes pipe sprites thinner to make room.
Rinary1 added a commit that referenced this pull request
Short description
Updates all 3 Nukie Outpost maps to include the Syndicate Delivery Console, the Target Station Map, and one canister of Pluoxium.
Why we need to add this
Bringing our Nukie Outposts up to Upstream standard for equipment. The Syndicate Delivery Console can redeem free bundles after set time intervals, currently only a Corpsman Bundle with some starter chems at 20 minutes but this may be expanded later. The Target Station Map shows the active Station the Nukies will be attacking, letting them plan without needing intense map knowledge or relying on our map render site to be up to date. And the Pluoxium is just better O2, which is a minor buff that will likely see no use but it's fun so why not.
Media (Video/Screenshots)
N/A
Checks
- I do not require assistance to complete the PR.
- Before posting/requesting review of a PR, I have verified that the changes work.
- I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
- I affirm that my changes are licensed under the Starlight Fork License and grant permission for use in this repository under its conditions.
Changelog
🆑
- tweak: Updated all 3 Nukie Outpost maps with the new Syndicate Delivery Console, Target Station Map, and 1 canister of Pluoxium (O2+). This brings us up to parity with Upstream's Outpost and preps us for any future additions to the Syndicate Delivery Console.
4 tasks
github-merge-queue Bot pushed a commit that referenced this pull request
Short description
Changes:
- Increased the volume of the canisters for the Funky-originating gases (BZ, Healium, …) from 1000 L to 1500 L (the standard gas can volume)
- Increased the standard fill value of canisters for the Funky-originating gases from 1871.71 mol to 2769.36 mol (the standard filling amount for 4500 kPa)
Gameplay effects:
- Funky gas cans will fit 50% more gas per kPa (thus matching the non-Funky cans). Currently the only way to get those cans is through Cargo or Salvage.
- BZ cans ordered through Cargo will contain 50% more BZ. As a result, their resale value has gone up from 2446.05 spesos to 3523.23 spesos, which is still solidly below the buying price of 6000 spesos.
- Cans of Funky gases received from Salvage will contain 50% more gas and will be ~50% more profitable when sold.
Testing:
- Spawned in all gas canisters and checked their volume and gas amount
- Bought a BZ canister and checked its volume and gas amount
- Spawned Salvage Canisters and checked their volume and gas amount
Why we need to add this
Funky Station uses a standard volume of 1000 L for gas cans, while Starlight (and Forky Station) use 1500 L. During the port of the gases from Funky to Forky the can volumes were not adjusted, and this was then carried over in the port from Forky to Starlight. The empty can variants (that were added on the Starlight side as part of the port) already have the correct volume of 1500 L.
This discrepancy was visible when ordering BZ from Cargo or when receiving cans from Salvage – all of these cans came with 1000 L rather than 1500 L and 33% less gas than expected. Repainting non-Funky cans to Funky colors did not change the volume, so the problem was not visible that way.
Media (Video/Screenshots)
A standard BZ can previously:
A standard BZ can with this PR:
Checks
- I do not require assistance to complete the PR.
- Before posting/requesting review of a PR, I have verified that the changes work.
- I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
- I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.
Changelog
🆑 JMxm5
- fix: Increased canister volume of the Funky-originating gases (BZ, Healium, …) from 1000 L to 1500 L to match the Starlight standard.
Athena-AI pushed a commit to Athena-AI/Far-Horizons-SS14 that referenced this pull request
Short description
Ports funky-station/forky-station#14 which is an MIT re-license of Funky Stations Atmos Gas's
Why we need to add this
Completes Electrolyzer for ss14Starlight/space-station-14#2983 Completes ss14Starlight/space-station-14#2457
Media (Video/Screenshots)
TO-DO
- Guidebook entry
- Rainbow Canister Sprites
Checks
- I do not require assistance to complete the PR.
- Before posting/requesting review of a PR, I have verified that the changes work.
- I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
- I affirm that my changes are licensed under the Starlight Fork License and grant permission for use in this repository under its conditions.
Changelog
🆑 marc-pelletier, CrazyPhantom
- add: BZ Gas
- add: Healium Gas
- add: Nitrium Gas
- add: Pluxium Gas
- add: Hydrogen Gas
- add: Hyper-Noblium Gas
- add: Proto-Nitrate Gas
- add: Zauker Gas
- add: Halon Gas
- add: Helium Gas
- add: Anti-Noblium Gas
- add: Electrolyzer Machine
- add: Metal Hydrogen Gear
- tweak: Nerf Frezon Price. 3 Spesos Per mol -> 1.2 Per mol 🆑 Conflee
- tweak: Canister Sprite changes.
Conflicts:
Content.Server/Atmos/EntitySystems/AtmosphereSystem.Hotspot.cs
Content.Server/StationEvents/Components/GasLeakRuleComponent.cs
Resources/Prototypes/Recipes/Lathes/Packs/engineering.yml
Resources/Prototypes/_StarLight/Entities/Structures/Storage/Canisters/gas_canisters.yml
Athena-AI pushed a commit to Athena-AI/Far-Horizons-SS14 that referenced this pull request
Short description
Changed the pressure atmos device can handle closer to real life values.
Why we need to add this
With the upcomming 2983 PR I think we should allow atmosians to proceed more reactions in pipes in order to make them worry less about the space in their department in current maps and allow them to utilize more layers with current pipe layering feature (also 5 layers comming from CrazyPhantom). This change will make the life of atmosians a little bit easier.
Media (Video/Screenshots)
Checks
- I do not require assistance to complete the PR.
- Before posting/requesting review of a PR, I have verified that the changes work.
- I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
- I affirm that my changes are licensed under the Starlight Fork License and grant permission for use in this repository under its conditions.
Changelog 🆑 AndrewTateOfficialSS14
- tweak: Changed atmos devices max pressure from 4500 to 9000 kPa.
ZombieNub pushed a commit to ZombieNub/space-station-14 that referenced this pull request
Short description
Changes:
- Increased the volume of the canisters for the Funky-originating gases (BZ, Healium, …) from 1000 L to 1500 L (the standard gas can volume)
- Increased the standard fill value of canisters for the Funky-originating gases from 1871.71 mol to 2769.36 mol (the standard filling amount for 4500 kPa)
Gameplay effects:
- Funky gas cans will fit 50% more gas per kPa (thus matching the non-Funky cans). Currently the only way to get those cans is through Cargo or Salvage.
- BZ cans ordered through Cargo will contain 50% more BZ. As a result, their resale value has gone up from 2446.05 spesos to 3523.23 spesos, which is still solidly below the buying price of 6000 spesos.
- Cans of Funky gases received from Salvage will contain 50% more gas and will be ~50% more profitable when sold.
Testing:
- Spawned in all gas canisters and checked their volume and gas amount
- Bought a BZ canister and checked its volume and gas amount
- Spawned Salvage Canisters and checked their volume and gas amount
Why we need to add this
Funky Station uses a standard volume of 1000 L for gas cans, while Starlight (and Forky Station) use 1500 L. During the port of the gases from Funky to Forky the can volumes were not adjusted, and this was then carried over in the port from Forky to Starlight. The empty can variants (that were added on the Starlight side as part of the port) already have the correct volume of 1500 L.
This discrepancy was visible when ordering BZ from Cargo or when receiving cans from Salvage – all of these cans came with 1000 L rather than 1500 L and 33% less gas than expected. Repainting non-Funky cans to Funky colors did not change the volume, so the problem was not visible that way.
Media (Video/Screenshots)
A standard BZ can previously:
A standard BZ can with this PR:
Checks
- I do not require assistance to complete the PR.
- Before posting/requesting review of a PR, I have verified that the changes work.
- I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
- I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.
Changelog
🆑 JMxm5
- fix: Increased canister volume of the Funky-originating gases (BZ, Healium, …) from 1000 L to 1500 L to match the Starlight standard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})