fix(assert): avoid panic on invalid regex in Regexp/NotRegexp (#1794) by kdt523 · Pull Request #1818 · stretchr/testify (original) (raw)
added 2 commits
fredbi added a commit to fredbi/testify that referenced this pull request
==================================
Panic situation is explained by stretchr#1699
The fix from the original author (@ccoVeille) has been adapted into our refactored assertions (with unit test).
fix: avoid panic on invalid regexp
Merged stretchr#1818
The original issue is described by: stretchr#1794
The original code contributed by @kdt523 has been adapted to our refactored assertions (with tests), taking into account the review comments from @ccoVeille. Thanks folks.
fix: documented the fixed merged from github.com/stretchr/testify
- fixes go-openapi#7
Also: since a dependency has been removed in the previous refactoring, updated the NOTICE to reflect this fact.
Signed-off-by: Frederic BIDON fredbi@yahoo.com
fredbi added a commit to go-openapi/testify that referenced this pull request
==================================
Panic situation is explained by stretchr#1699
The fix from the original author (@ccoVeille) has been adapted into our refactored assertions (with unit test).
fix: avoid panic on invalid regexp
Merged stretchr#1818
The original issue is described by: stretchr#1794
The original code contributed by @kdt523 has been adapted to our refactored assertions (with tests), taking into account the review comments from @ccoVeille. Thanks folks.
fix: documented the fixed merged from github.com/stretchr/testify
- fixes #7
Also: since a dependency has been removed in the previous refactoring, updated the NOTICE to reflect this fact.
Signed-off-by: Frederic BIDON fredbi@yahoo.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})