Add OpenMP dialect to the dialect registry by DavidTruby · Pull Request #244 · tensorflow/mlir (original) (raw)
This repository was archived by the owner on Apr 23, 2021. It is now read-only.
Conversation12 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This dialect will be used by flang for OpenMP code generation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
A Googler has manually verified that the CLAs look good.
(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)
ℹ️ Googlers: Go here for more info.
Just to confirm: is this dialect gonna be "abstract" or "generic" OpenMP or is it gonna be "Fortran Specific" OpenMP? (for instance you may let things like types creep in). If the later then I rather see it reflected in the name.
Just to confirm: is this dialect gonna be "abstract" or "generic" OpenMP or is it gonna be "Fortran Specific" OpenMP? (for instance you may let things like types creep in). If the later then I rather see it reflected in the name.
Also: if this is a generic OpenMP dialect and not Fortran specific, I would expect it to be submitted upstream and not live in the flang tree? Can you clarify your plans about this?
The current plan is to make this a generic OpenMP IR without Fortran specific features as we would like to leave open the possibility for clang to use this if(/when?) they move to an mlir-based code generator. We are also currently planning to submit this upstream in mlir and not in the flang tree.
It's possible of course that when we start implementing this we might find we need Fortran specific things anyway, but the plan is to avoid anything Fortran specific if at all possible.
Great! Thanks, I'd encourage you to send an RFC with the dialect design and the first "milestone" you'd like to reach: it'll likely smooth out patch review :)
I'd encourage you to send an RFC with the dialect design and the first "milestone" you'd like to reach: it'll likely smooth out patch review :)
Most of the discussion on dialect design has been happening in the flang community. We have some design walkthroughs, I'll see if we can get some cross-conversation going here with the MLIR community.
I have also been preparing a patch to add an OpenMP dialect and a single operation omp.barrier so that we can start work on the dialect. This probably qualifies as the first milestone we're aiming for :)
Most of the discussion on dialect design has been happening in the flang community. We have some design walkthroughs, I'll see if we can get some cross-conversation going here with the MLIR community.
Thanks! We will definitely need something like this before reviewing patches I think
I'd be quite interested in also seeing what the end to end path to execution looks like. It would be great if some execution flow could be made available early in the MLIR repo to experiment.
On Tue, Nov 19, 2019, 4:48 PM Mehdi Amini ***@***.***> wrote: Most of the discussion on dialect design has been happening in the flang community. We have some design walkthroughs, I'll see if we can get some cross-conversation going here with the MLIR community. Thanks! We will definitely need something like this before reviewing patches I think — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#244?email_source=notifications&email_token=ACNNU5E53QAXPTRGUU7WQJDQURNL5A5CNFSM4JOV4762YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEP4RDY#issuecomment-555731087>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACNNU5GP2TI6Z2JWO6BZ7ALQURNL5ANCNFSM4JOV476Q> .
Is this waiting on more design info to be merged or can we get this initial registration in before then?
Is this waiting on more design info to be merged or can we get this initial registration in before then?
No this is all good, for some reason our integration script failed and I didn't notice. I restarted it and hopefully it should go through! Sorry for the delay.
joker-eph pushed a commit to joker-eph/llvm-project-with-mlir that referenced this pull request
Closes #244
COPYBARA_INTEGRATE_REVIEW=tensorflow/mlir#244 from DavidTruby:openmp 30e2638ee678188575dd5aeb3f7fa51d93369f5f PiperOrigin-RevId: 282607397
tensorflow-copybara pushed a commit to tensorflow/tensorflow that referenced this pull request
Closes #244
COPYBARA_INTEGRATE_REVIEW=tensorflow/mlir#244 from DavidTruby:openmp 30e2638ee678188575dd5aeb3f7fa51d93369f5f PiperOrigin-RevId: 282607397 Change-Id: I6cf93102444283a69355d43bd8ede604f31eb8c8
swift-ci pushed a commit to swiftlang/llvm-project that referenced this pull request