chore: increase MSRV to 1.70 by Darksonn · Pull Request #6645 · tokio-rs/tokio (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits1 Checks78 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Darksonn

Mio v1 was recently released, and it requires an MSRV of 1.70.0 for various changes that mio is using to get rid of its SocketAddr type and instead use the std version. This PR proposes to bump the MSRV of Tokio to 1.70.

The main disadvantage is that debian stable is still at rustc 1.63.

Refs: #6635

@carllerche

Looks like the next debian stable will have 1.75. I don't know when it will be released though.

I'm fine with whatever I guess, but we probably need to keep an LTS that works on debian stable working.

Thomasdezeeuw

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would very much help with the update to Mio v1 (#6635).

@Darksonn

@carllerche It looks like it will be ~1 year until debian stable will start using 1.75.0. I don't think we should wait for that. We can make an LTS release now, then bump the MSRV afterwards?

@carllerche

@Darksonn

This was referenced

Jul 22, 2024

notmandatory added a commit to bitcoindevkit/bdk that referenced this pull request

Jul 27, 2024

@notmandatory

28d7530 ci: pin tokio to 1.38.1 to support MSRV 1.63 (Steve Myers)

Pull request description:

Description

The latest tokio minor version update from 1.38.1 to 1.39.1 changed it's MSRV from 1.63.0 to 1.70.0, breaking our CI MSRV 1.63 testing. This PR pins tokio back to 1.38.1 for our CI MSRV testing.

Notes to the reviewers

tokio-rs/tokio#6645

https://crates.io/crates/tokio/versions

Checklists

All Submissions:

ACKs for top commit: LagginTimes: ACK 28d7530 ValuedMammal: ACK 28d7530 oleonardolima: ACK 28d7530

Tree-SHA512: 9eef750422cb8c3faa15771438e790afae44362d7c77e1d36cf70816ac7dabdd2e408e14502836ec86f845a2f1fe82905000c681fb6b4e873b036a41a280abd9