[BugFix] Don't start a Ray cluster when not using Ray by njhill · Pull Request #5570 · vllm-project/vllm (original) (raw)

@njhill

The logic to auto-select the distributed executor backend uses ray.util.get_current_placement_group() to check whether it's already running in a Ray placement group, but this function has a side effect of starting a Ray cluster if it's not already started.

The result is that a Ray cluster gets started even when defaulting to the multiprocessing distributed backend.

simon-mo

approved these changes Jun 15, 2024

@njhill njhill deleted the dont-init-ray branch

June 15, 2024 23:31

kzawora-intel added a commit to HabanaAI/vllm-fork that referenced this pull request

Jul 2, 2024

Co-authored-by: Jianan Gu jianan.gu@intel.com

Co-authored-by: Roger Wang ywang@roblox.com

Co-authored-by: Michael Goin michael@neuralmagic.com Co-authored-by: youkaichao youkaichao@gmail.com Co-authored-by: zifeitong zifei.tong@parasail.io Co-authored-by: Robert Shaw 114415538+robertgshaw2-neuralmagic@users.noreply.github.com

Co-authored-by: Philipp Moritz pcmoritz@gmail.com

Co-authored-by: simon-mo simon.mo@hey.com

Co-authored-by: mgoin michael@neuralmagic.com Co-authored-by: Dipika Sikka dipikasikka1@gmail.com

Signed-off-by: Thomas Parnell tpa@zurich.ibm.com

Signed-off-by: Lei Wen wenlei03@qiyi.com Co-authored-by: Lei Wen wenlei03@qiyi.com

Co-authored-by: Cyrus Leung tlleungac@connect.ust.hk

Co-authored-by: Liqian Chen liqian.chen@deeplang.ai

Co-authored-by: Jiang Li jiang1.li@intel.com Co-authored-by: Abhilash Majumder abhilash.majumder@intel.com Co-authored-by: Abhilash Majumder 30946547+abhilash1910@users.noreply.github.com

[CI] Improve the readability of performance benchmarking results and prepare for upcoming performance dashboard (vllm-project#5571)

Signed-off-by: Joe Runde Joseph.Runde@ibm.com

[bugfix][distributed] do not error if two processes do not agree on p2p capability (vllm-project#5612)

Signed-off-by: kevin kevin@anyscale.com

This PR adds basic support for OpenTelemetry distributed tracing. It includes changes to enable tracing functionality and improve monitoring capabilities.

I've also added a markdown with print-screens to guide users how to use this feature. You can find it here

Signed-off-by: kevin kevin@anyscale.com

Signed-off-by: Thomas Parnell tpa@zurich.ibm.com

Signed-off-by: Thomas Parnell tpa@zurich.ibm.com

Signed-off-by: kevin kevin@anyscale.com

Signed-off-by: Rafael Vasquez rafvasq21@gmail.com

Signed-off-by: kevin kevin@anyscale.com

Co-authored-by: Varun Sundar Rabindranath varun@neuralmagic.com

Co-authored-by: Varun Sundar Rabindranath varun@neuralmagic.com

Signed-off-by: Thomas Parnell tpa@zurich.ibm.com

Co-authored-by: Thomas Parnell tpa@zurich.ibm.com Co-authored-by: Nick Hill nickhill@us.ibm.com Co-authored-by: Davis Wertheimer Davis.Wertheimer@ibm.com

Co-authored-by: Antoni Baum antoni.baum@protonmail.com

Co-authored-by: Cody Yu hao.yu.cody@gmail.com

Co-authored-by: Roger Wang ywang@roblox.com

Co-authored-by: Varun Sundar Rabindranath varun@neuralmagic.com

Signed-off-by: kevin kevin@anyscale.com

Signed-off-by: Thomas Parnell tpa@zurich.ibm.com

Signed-off-by: Stephanie Wang swang@cs.berkeley.edu Signed-off-by: Stephanie swang@anyscale.com Co-authored-by: Stephanie swang@anyscale.com

Co-authored-by: Chih-Chieh-Yang 7364402+cyang49@users.noreply.github.com Co-authored-by: Lucas Wilkinson lwilkinson@neuralmagic.com

Co-authored-by: Abhinav Goyal abhinav.goyal@flipkart.com

Signed-off-by: Xiaowei Jiang xwjiang2010@gmail.com

Signed-off-by: Xiaowei Jiang xwjiang2010@gmail.com Co-authored-by: Roger Wang ywang@roblox.com

Co-authored-by: ywang96 ywang@roblox.com

Signed-off-by: Thomas Parnell tpa@zurich.ibm.com

Signed-off-by: Xiaowei Jiang xwjiang2010@gmail.com

Co-authored-by: Robert Shaw <rshaw@neuralmagic>

Co-authored-by: Robert Shaw <rshaw@neuralmagic>

Co-authored-by: Philipp Moritz pcmoritz@gmail.com

Co-authored-by: Robert Shaw <rshaw@neuralmagic>

Co-authored-by: LiuXiaoxuanPKU llilyliupku@gmail.com, bong-furiosa bongwon.jang@furiosa.ai

Co-authored-by: Antoni Baum antoni.baum@protonmail.com

Signed-off-by: Joe Runde joe@joerun.de

Co-authored-by: Cyrus Leung cyrus.tl.leung@gmail.com

Co-authored-by: Michael Goin michael@neuralmagic.com Co-authored-by: Robert Shaw <rshaw@neuralmagic>

Co-authored-by: Robert Shaw <rshaw@neuralmagic>

[ci][distributed] fix some cuda init that makes it necessary to use spawn (vllm-project#5991)

Co-authored-by: Cyrus Leung cyrus.tl.leung@gmail.com

Co-authored-by: sang sangcho@anyscale.com

Co-authored-by: rshaw@neuralmagic.com <rshaw@neuralmagic>

Co-authored-by: Robert Shaw <rshaw@neuralmagic>

Co-authored-by: Simon Mo simon.mo@hey.com

Signed-off-by: Thomas Parnell tpa@zurich.ibm.com Co-authored-by: Joshua Rosenkranz jmrosenk@us.ibm.com

Signed-off-by: Xiaowei Jiang xwjiang2010@gmail.com Co-authored-by: Cyrus Leung cyrus.tl.leung@gmail.com Co-authored-by: Roger Wang ywang@roblox.com


Signed-off-by: Thomas Parnell tpa@zurich.ibm.com Signed-off-by: Lei Wen wenlei03@qiyi.com Signed-off-by: Joe Runde Joseph.Runde@ibm.com Signed-off-by: kevin kevin@anyscale.com Signed-off-by: Rafael Vasquez rafvasq21@gmail.com Signed-off-by: Stephanie Wang swang@cs.berkeley.edu Signed-off-by: Stephanie swang@anyscale.com Signed-off-by: Xiaowei Jiang xwjiang2010@gmail.com Signed-off-by: Joe Runde joe@joerun.de Co-authored-by: Li, Jiang jiang1.li@intel.com Co-authored-by: Jianan Gu jianan.gu@intel.com Co-authored-by: Woosuk Kwon woosuk.kwon@berkeley.edu Co-authored-by: Cyrus Leung tlleungac@connect.ust.hk Co-authored-by: Roger Wang ywang@roblox.com Co-authored-by: Tyler Michael Smith tyler@neuralmagic.com Co-authored-by: Michael Goin michael@neuralmagic.com Co-authored-by: youkaichao youkaichao@gmail.com Co-authored-by: zifeitong zifei.tong@parasail.io Co-authored-by: Robert Shaw 114415538+robertgshaw2-neuralmagic@users.noreply.github.com Co-authored-by: Cody Yu hao.yu.cody@gmail.com Co-authored-by: Philipp Moritz pcmoritz@gmail.com Co-authored-by: Antoni Baum antoni.baum@protonmail.com Co-authored-by: Jie Fu (傅杰) jiefu@tencent.com Co-authored-by: Allen.Dou allen.dou@hotmail.com Co-authored-by: Simon Mo simon.mo@hey.com Co-authored-by: Kuntai Du kuntai@uchicago.edu Co-authored-by: Dipika Sikka dipikasikka1@gmail.com Co-authored-by: Sanger Steel sangersteel@gmail.com Co-authored-by: Thomas Parnell tpa@zurich.ibm.com Co-authored-by: leiwen83 leiwen83@users.noreply.github.com Co-authored-by: Lei Wen wenlei03@qiyi.com Co-authored-by: SangBin Cho rkooo567@gmail.com Co-authored-by: Alexander Matveev 59768536+alexm-neuralmagic@users.noreply.github.com Co-authored-by: Nick Hill nickhill@us.ibm.com Co-authored-by: Amit Garg gargamit@microsoft.com Co-authored-by: Charles Riggins liqianchen123@foxmail.com Co-authored-by: Liqian Chen liqian.chen@deeplang.ai Co-authored-by: zhyncs me@zhyncs.com Co-authored-by: Kunshang Ji kunshang.ji@intel.com Co-authored-by: Abhilash Majumder abhilash.majumder@intel.com Co-authored-by: Abhilash Majumder 30946547+abhilash1910@users.noreply.github.com Co-authored-by: Bruce Fontaine bruce@2.7182.net Co-authored-by: zifeitong zifeitong@gmail.com Co-authored-by: sroy745 142070531+sroy745@users.noreply.github.com Co-authored-by: Isotr0py 2037008807@qq.com Co-authored-by: Joe Runde joe@joerun.de Co-authored-by: Chang Su chang.s.su@oracle.com Co-authored-by: Roger Wang 136131678+ywang96@users.noreply.github.com Co-authored-by: Kevin H. Luu kevin@anyscale.com Co-authored-by: Ronen Schaffer ronen.schaffer@ibm.com Co-authored-by: sergey-tinkoff 167607910+sergey-tinkoff@users.noreply.github.com Co-authored-by: milo157 43028253+milo157@users.noreply.github.com Co-authored-by: Shukant Pal SukantK2002@outlook.com Co-authored-by: Hongxia Yang 62075498+hongxiayang@users.noreply.github.com Co-authored-by: DearPlanet junsong.zhang2021.work@outlook.com Co-authored-by: Rafael Vasquez rafvasq21@gmail.com Co-authored-by: Varun Sundar Rabindranath varunsundar08@gmail.com Co-authored-by: Varun Sundar Rabindranath varun@neuralmagic.com Co-authored-by: Joshua Rosenkranz joshua.rosenkranz@gmail.com Co-authored-by: Davis Wertheimer Davis.Wertheimer@ibm.com Co-authored-by: Jinzhen Lin linjinzhen@hotmail.com Co-authored-by: Jee Li pandaleefree@163.com Co-authored-by: rohithkrn rohith.nallamaddi@gmail.com Co-authored-by: Murali Andoorveedu 37849411+andoorve@users.noreply.github.com Co-authored-by: Woo-Yeon Lee wooyeonlee0@gmail.com Co-authored-by: Matt Wong 156021403+mawong-amd@users.noreply.github.com Co-authored-by: aws-patlange 90803007+aws-patlange@users.noreply.github.com Co-authored-by: Stephanie Wang swang@cs.berkeley.edu Co-authored-by: Stephanie swang@anyscale.com Co-authored-by: Luka Govedič ProExpertProg@users.noreply.github.com Co-authored-by: Chih-Chieh-Yang 7364402+cyang49@users.noreply.github.com Co-authored-by: Lucas Wilkinson lwilkinson@neuralmagic.com Co-authored-by: sasha0552 admin@sasha0552.org Co-authored-by: Chip Kerchner 49959681+ChipKerchner@users.noreply.github.com Co-authored-by: Abhinav Goyal abhinav.goyal@flipkart.com Co-authored-by: xwjiang2010 87673679+xwjiang2010@users.noreply.github.com Co-authored-by: Divakar Verma 137818590+divakar-amd@users.noreply.github.com Co-authored-by: Ilya Lavrenov ilya.lavrenov@intel.com Co-authored-by: Robert Shaw <rshaw@neuralmagic> Co-authored-by: wangding zeng 155410488+zwd003@users.noreply.github.com Co-authored-by: Lily Liu lilyliupku@gmail.com Co-authored-by: LiuXiaoxuanPKU llilyliupku@gmail.com, bong-furiosa bongwon.jang@furiosa.ai Co-authored-by: mcalman 68564154+mcalman@users.noreply.github.com Co-authored-by: William Lin SolitaryThinker@users.noreply.github.com Co-authored-by: Cyrus Leung cyrus.tl.leung@gmail.com Co-authored-by: llmpros 10524065+llmpros@users.noreply.github.com Co-authored-by: sang sangcho@anyscale.com Co-authored-by: Avshalom Manevich 12231371+avshalomman@users.noreply.github.com Co-authored-by: James Whedbee jamesw@telnyx.com Co-authored-by: Joshua Rosenkranz jmrosenk@us.ibm.com Co-authored-by: danieljannai21 100521221+danieljannai21@users.noreply.github.com

xjpang pushed a commit to xjpang/vllm that referenced this pull request

Jul 8, 2024

@njhill

xjpang pushed a commit to xjpang/vllm that referenced this pull request

Jul 24, 2024

@njhill

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})