[css-fonts][css-multicol][css-scroll-anchoring][css-scrollbars][css-shapes][css-size-adjust][css-transforms][css-ui] Update Computed Value and Animation lines to new format. by tabatkins · Pull Request #3198 · w3c/csswg-drafts (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation14 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to css-scrollbars look good to me.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to fonts 4 look good to me.
Changes to fonts 3 (Fonts.html) look fine too but will need to be merged in as errata first (and manually, because the .src.html diverged from the final version of the spec).
Multicol 1 & 2, as well as css-ui 3 and 4 OK, except for 1 comment: #3198 (comment)
@svgeesus Could you clarify if you're requesting changes to this patch before merging, or if your comment is about something else that needs to happen outside of the changes to these files in this repository? (IIRC I edited the .src.html source and the .html output directly so whatever's in sync or not is still in sync or not as before.)
I'm not requesting changes to the patch. I'm just saying that updating the files here doesn't update the Rec, and that the .src.html format is a pain in the ass.
(sent in a hurry while on vacation)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
css-size-adjust change looks fine
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one nitpick you can fix or leave as-is
…hapes][css-size-adjust][css-transforms][css-ui] Update Computed Value and Animation lines to new format.
Fixed the things that were asked for during the review, and resolved the conflicts. Merging.
Reviewers
