Prefer Guice injection by elharo · Pull Request #79 · apache/maven-war-plugin (original) (raw)

Skip to content

Sign in

Appearance settings

View all features

View all solutions

View all resources

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

apache / maven-war-plugin Public

Additional navigation options

Merged

elharo

merged 2 commits into

masterfrom

guice

Dec 26, 2024

ConversationCommits (2)ChecksFiles changed

Merged

Prefer Guice injection#79

elharo

merged 2 commits into

masterfrom

guice

Conversation

@elharo

@elharo elharo commented

Dec 19, 2024

Copy link Copy Markdown

Contributor

No description provided.

@elharo

[Prefer Guice injection](/apache/maven-war-plugin/pull/79/commits/8eb9309f876912ee49c532321253b53da8f32dee "Prefer Guice injection")

[8eb9309](/apache/maven-war-plugin/pull/79/commits/8eb9309f876912ee49c532321253b53da8f32dee)

@elharo elharo marked this pull request as ready for review

December 19, 2024 22:23

@elharo elharo requested a review from slachiewicz

December 19, 2024 22:23

@slachiewicz slachiewicz removed their request for review

December 22, 2024 16:43

@elharo

[Remove plexus components.xml](/apache/maven-war-plugin/pull/79/commits/30489b64eba1013c40045080253c6910e564e63d "Remove plexus components.xml")

[30489b6](/apache/maven-war-plugin/pull/79/commits/30489b64eba1013c40045080253c6910e564e63d)

@elharo elharo requested a review from slawekjaranowski

December 24, 2024 14:03

Bukama

Bukama approved these changes Dec 25, 2024

View reviewed changes

@Bukama Bukama left a comment

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non binding approval

slachiewicz

slachiewicz approved these changes Dec 26, 2024

View reviewed changes

@elharo elharo merged commit 1e267a6 into master

Dec 26, 2024

@elharo elharo deleted the guice branch

December 26, 2024 12:45

@slawekjaranowski slawekjaranowski added the maintenance label

Oct 15, 2025

@slawekjaranowski slawekjaranowski assigned elharo

Oct 15, 2025

@slawekjaranowski slawekjaranowski added this to the 3.4.1 milestone

Oct 15, 2025

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@Bukama Bukama Bukama approved these changes

@slachiewicz slachiewicz slachiewicz approved these changes

@slawekjaranowski slawekjaranowski Awaiting requested review from slawekjaranowski

Assignees

@elharo elharo

Labels

maintenance

Projects

None yet

Milestone

3.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@elharo @Bukama @slachiewicz @slawekjaranowski