feat: replace cache-content-type with mime-types directly by 3imed-jaberi · Pull Request #1886 · koajs/koa (original) (raw)
Checklist
- I have ensured my pull request is not behind the main or master branch of the original repository.
- I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
- I have written a commit message that passes commitlint linting.
- I have ensured that my code changes pass linting tests.
- I have ensured that my code changes pass unit tests.
- I have described my pull request and the reasons for code changes along with context if necessary.
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 99.90%. Comparing base (2f6e814) to head (40d41e6).
Report is 1 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@ ## master #1886 +/- ##
Coverage 99.90% 99.90%
Files 9 9
Lines 2046 2048 +2
- Hits 2044 2046 +2
Misses 2 2
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@jonathanong I’ve removed cache-content-type because it’s not in sync with the latest mime-types. I think we should rely directly on the upstream mime-types package instead. If you’re on board, we can move forward with this PR. Otherwise, happy to close it!
@fengmk2 @dead-horse why do we need to cache the content type? I think all the mime types are already in memory
@3imed-jaberi my preference would be to just remove caching entirely
feat: replcae cache-content-type with mime-types directly (keeps ylru cache) feat: replace cache-content-type with mime-types directly
Cache is no longer needed +1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})