test: first attempt for flaky fix by metcoder95 · Pull Request #2337 · nodejs/undici (original) (raw)
Conversation
This relates to...
Fixes #2321
Rationale
A race condition seems to happen between the server response and the assertion for it few lines after. This is a very rare condition, but it happens. This PR fixes it by waiting for the response to be fully read before asserting it.
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status
- I have read and agreed to the Developer's Certificate of Origin
- Tested
- Benchmarked (optional)
- Documented
- Review ready
- In review
- Merge ready
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.83%. Comparing base (e39a632) to head (c355316).
⚠️ Report is 1303 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@ ## main #2337 +/- ##
Coverage 85.54% 85.83% +0.28%
Files 76 76
Lines 6858 6870 +12- Hits 5867 5897 +30
- Misses 991 973 -18
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
It seems to solve the issue, but running the whole suite once more to verify
Windows seems to be failing still
windows is failing on the WPTs for The syntax of the command is incorrect....
Tests seem stable, failures are either redirect, windows WPTs, and now npm ECONNRESET
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
kodiakhq Bot referenced this pull request in X-oss-byte/Canary-nextjs
kodiakhq Bot referenced this pull request in X-oss-byte/Nextjs
kodiakhq Bot referenced this pull request in ascorbic/unpic-img
renovate Bot referenced this pull request in specfy/specfy
gr2m referenced this pull request in octokit/rest.js
crysmags pushed a commit to crysmags/undici that referenced this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})