refactor: better integrity check by tsctx · Pull Request #2462 · nodejs/undici (original) (raw)
If the integrity is null, it is safe to delete it because it will be converted to the string 'null' by DOMString.
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.67%. Comparing base (e39a632) to head (893cde9).
⚠️ Report is 1433 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@ ## main #2462 +/- ##
Coverage 85.54% 85.67% +0.12%
Files 76 77 +1
Lines 6858 7056 +198- Hits 5867 6045 +178
- Misses 991 1011 +20
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be the other way around. Remove the !== undefined and keep the != null
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@tsctx I don't intend to discourage you. Some of the contributions you have been making have been absolutely great and I hope you continue doing so.
However, these small changes with limited value add extra work for us. I would appreciate it if we could reduce the amount of such minor refactorings and optimizations PRs.
kodiakhq Bot referenced this pull request in X-oss-byte/Nextjs
kodiakhq Bot referenced this pull request in X-oss-byte/Canary-nextjs
kodiakhq Bot referenced this pull request in ascorbic/unpic-img
gr2m referenced this pull request in octokit/rest.js
renovate Bot referenced this pull request in specfy/specfy
kodiakhq Bot referenced this pull request in X-oss-byte/Nextjs
crysmags pushed a commit to crysmags/undici that referenced this pull request
refactor: better integrity check
better
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})