[Ffmpeg-devel] [PATCH] from DivX, Part 7: MSVC fixes (original) (raw)

Diego Biurrun diego
Thu Feb 2 15:39:24 CET 2006

On Sat, Jan 28, 2006 at 01:32:46AM +0100, Michael Niedermayer wrote:

On Fri, Jan 27, 2006 at 09:11:42AM -1000, Steve Lhomme wrote: > > Michael Niedermayer wrote: > > > >On Thu, Jan 26, 2006 at 12:16:21PM -1000, Steve Lhomme wrote: > >> > >>Here is the patch, I used DECLAREALIGNED8() and DECLAREALIGNED16() > >>I might be better than having a "random" alignement size, especially > >>since some sizes are mapped to different values that the one set on some > >>platforms... > > > >[...] _> >>-uint16t align8 invzigzagdirect16[64] = {0, }; > >>+static DECLAREALIGNED8(uint16t,invzigzagdirect16static[64]) = {0, > >>}; > > > >that doesnt look good > > And it didn't build in MinGW. Here is the fixed patch. patch looks ok, can be applied if it compiles & regression tests pass

Fails on PPC:

gcc -O3 -g -Wall -Wno-switch -maltivec -mabi=altivec -Wdeclaration-after-statement -DHAVE_AV_CONFIG_H -I.. -I'/home/diego/src/ffmpeg'/libavutil -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_GNU_SOURCE -c -o ppc/dsputil_h264_altivec.o ppc/dsputil_h264_altivec.c ppc/dsputil_h264_altivec.c: In function 'put_h264_qpel16_mc10_altivec': ppc/dsputil_h264_altivec.c:227: error: syntax error before '__align16' ppc/dsputil_h264_altivec.c:227: error: 'temp' undeclared (first use in this function) ppc/dsputil_h264_altivec.c:227: error: (Each undeclared identifier is reported only once ppc/dsputil_h264_altivec.c:227: error: for each function it appears in.) ppc/dsputil_h264_altivec.c: In function 'put_h264_qpel16_mc30_altivec': ppc/dsputil_h264_altivec.c:227: error: syntax error before '__align16' ppc/dsputil_h264_altivec.c:227: error: 'temp' undeclared (first use in this function) ppc/dsputil_h264_altivec.c: In function 'put_h264_qpel16_mc01_altivec': ppc/dsputil_h264_altivec.c:227: error: syntax error before '__align16' ppc/dsputil_h264_altivec.c:227: error: 'temp' undeclared (first use in this function) ppc/dsputil_h264_altivec.c: In function 'put_h264_qpel16_mc03_altivec': ppc/dsputil_h264_altivec.c:227: error: syntax error before '__align16' ppc/dsputil_h264_altivec.c:227: error: 'temp' undeclared (first use in this function) ppc/dsputil_h264_altivec.c: In function 'put_h264_qpel16_mc11_altivec': ppc/dsputil_h264_altivec.c:227: error: syntax error before '__align16' ppc/dsputil_h264_altivec.c:227: error: 'temp' undeclared (first use in this function) ppc/dsputil_h264_altivec.c: In function 'put_h264_qpel16_mc31_altivec': ppc/dsputil_h264_altivec.c:227: error: syntax error before '__align16' ppc/dsputil_h264_altivec.c:227: error: 'temp' undeclared (first use in this function) ppc/dsputil_h264_altivec.c: In function 'put_h264_qpel16_mc13_altivec': ppc/dsputil_h264_altivec.c:227: error: syntax error before '__align16' ppc/dsputil_h264_altivec.c:227: error: 'temp' undeclared (first use in this function) ppc/dsputil_h264_altivec.c: In function 'put_h264_qpel16_mc33_altivec': ppc/dsputil_h264_altivec.c:227: error: syntax error before '__align16' ppc/dsputil_h264_altivec.c:227: error: 'temp' undeclared (first use in this function) ppc/dsputil_h264_altivec.c: In function 'put_h264_qpel16_mc22_altivec': ppc/dsputil_h264_altivec.c:227: error: syntax error before '__align16' ppc/dsputil_h264_altivec.c:227: error: 'temp' undeclared (first use in this function) ppc/dsputil_h264_altivec.c: In function 'put_h264_qpel16_mc21_altivec': ppc/dsputil_h264_altivec.c:227: error: syntax error before '__align16' ppc/dsputil_h264_altivec.c:227: error: 'temp' undeclared (first use in this function) ppc/dsputil_h264_altivec.c: In function 'put_h264_qpel16_mc23_altivec': ppc/dsputil_h264_altivec.c:227: error: syntax error before '__align16' ppc/dsputil_h264_altivec.c:227: error: 'temp' undeclared (first use in this function) ppc/dsputil_h264_altivec.c: In function 'put_h264_qpel16_mc12_altivec': ppc/dsputil_h264_altivec.c:227: error: syntax error before '__align16' ppc/dsputil_h264_altivec.c:227: error: 'temp' undeclared (first use in this function) ppc/dsputil_h264_altivec.c: In function 'put_h264_qpel16_mc32_altivec': ppc/dsputil_h264_altivec.c:227: error: syntax error before '__align16' ppc/dsputil_h264_altivec.c:227: error: 'temp' undeclared (first use in this function) ppc/dsputil_h264_altivec.c: In function 'avg_h264_qpel16_mc10_altivec': ppc/dsputil_h264_altivec.c:228: error: syntax error before '__align16' ppc/dsputil_h264_altivec.c:228: error: 'temp' undeclared (first use in this function) ppc/dsputil_h264_altivec.c: In function 'avg_h264_qpel16_mc30_altivec': ppc/dsputil_h264_altivec.c:228: error: syntax error before '__align16' ppc/dsputil_h264_altivec.c:228: error: 'temp' undeclared (first use in this function) ppc/dsputil_h264_altivec.c: In function 'avg_h264_qpel16_mc01_altivec': ppc/dsputil_h264_altivec.c:228: error: syntax error before '__align16' ppc/dsputil_h264_altivec.c:228: error: 'temp' undeclared (first use in this function) ppc/dsputil_h264_altivec.c: In function 'avg_h264_qpel16_mc03_altivec': ppc/dsputil_h264_altivec.c:228: error: syntax error before '__align16' ppc/dsputil_h264_altivec.c:228: error: 'temp' undeclared (first use in this function) ppc/dsputil_h264_altivec.c: In function 'avg_h264_qpel16_mc11_altivec': ppc/dsputil_h264_altivec.c:228: error: syntax error before '__align16' ppc/dsputil_h264_altivec.c:228: error: 'temp' undeclared (first use in this function) ppc/dsputil_h264_altivec.c: In function 'avg_h264_qpel16_mc31_altivec': ppc/dsputil_h264_altivec.c:228: error: syntax error before '__align16' ppc/dsputil_h264_altivec.c:228: error: 'temp' undeclared (first use in this function) ppc/dsputil_h264_altivec.c: In function 'avg_h264_qpel16_mc13_altivec': ppc/dsputil_h264_altivec.c:228: error: syntax error before '__align16' ppc/dsputil_h264_altivec.c:228: error: 'temp' undeclared (first use in this function) ppc/dsputil_h264_altivec.c: In function 'avg_h264_qpel16_mc33_altivec': ppc/dsputil_h264_altivec.c:228: error: syntax error before '__align16' ppc/dsputil_h264_altivec.c:228: error: 'temp' undeclared (first use in this function) ppc/dsputil_h264_altivec.c: In function 'avg_h264_qpel16_mc22_altivec': ppc/dsputil_h264_altivec.c:228: error: syntax error before '__align16' ppc/dsputil_h264_altivec.c:228: error: 'temp' undeclared (first use in this function) ppc/dsputil_h264_altivec.c: In function 'avg_h264_qpel16_mc21_altivec': ppc/dsputil_h264_altivec.c:228: error: syntax error before '__align16' ppc/dsputil_h264_altivec.c:228: error: 'temp' undeclared (first use in this function) ppc/dsputil_h264_altivec.c: In function 'avg_h264_qpel16_mc23_altivec': ppc/dsputil_h264_altivec.c:228: error: syntax error before '__align16' ppc/dsputil_h264_altivec.c:228: error: 'temp' undeclared (first use in this function) ppc/dsputil_h264_altivec.c: In function 'avg_h264_qpel16_mc12_altivec': ppc/dsputil_h264_altivec.c:228: error: syntax error before '__align16' ppc/dsputil_h264_altivec.c:228: error: 'temp' undeclared (first use in this function) ppc/dsputil_h264_altivec.c: In function 'avg_h264_qpel16_mc32_altivec': ppc/dsputil_h264_altivec.c:228: error: syntax error before '__align16' ppc/dsputil_h264_altivec.c:228: error: 'temp' undeclared (first use in this function) make: *** [ppc/dsputil_h264_altivec.o] Error 1

Diego

More information about the ffmpeg-devel mailing list