[Ffmpeg-devel] [PATCH] from DivX, Part 7: MSVC fixes (original) (raw)

Steve Lhomme steve.lhomme
Thu Feb 2 23:12:18 CET 2006

Hi,

Diego Biurrun wrote:

On Sat, Jan 28, 2006 at 01:32:46AM +0100, Michael Niedermayer wrote:

On Fri, Jan 27, 2006 at 09:11:42AM -1000, Steve Lhomme wrote:

Michael Niedermayer wrote:

On Thu, Jan 26, 2006 at 12:16:21PM -1000, Steve Lhomme wrote:

Here is the patch, I used DECLAREALIGNED8() and DECLAREALIGNED16() I might be better than having a "random" alignement size, especially since some sizes are mapped to different values that the one set on some platforms... [...] _-uint16t align8 invzigzagdirect16[64] = {0, }; +static DECLAREALIGNED8(uint16t,invzigzagdirect16static[64]) = {0, }; that doesnt look good And it didn't build in MinGW. Here is the fixed patch. patch looks ok, can be applied if it compiles & regression tests pass Fails on PPC: gcc -O3 -g -Wall -Wno-switch -maltivec -mabi=altivec -Wdeclaration-after-statement -DHAVEAVCONFIGH -I.. -I'/home/diego/src/ffmpeg'/libavutil -DFILEOFFSETBITS=64 -DLARGEFILESOURCE -DGNUSOURCE -c -o ppc/dsputilh264altivec.o ppc/dsputilh264altivec.c ppc/dsputilh264altivec.c: In function 'puth264qpel16mc10altivec': _ppc/dsputilh264altivec.c:227: error: syntax error before 'align16' ppc/dsputilh264altivec.c:227: error: 'temp' undeclared (first use in this function) ppc/dsputilh264altivec.c:227: error: (Each undeclared identifier is reported only once ppc/dsputilh264altivec.c:227: error: for each function it appears in.) ppc/dsputilh264altivec.c: In function 'puth264qpel16mc30altivec': _ppc/dsputilh264altivec.c:227: error: syntax error before 'align16' ppc/dsputilh264altivec.c:227: error: 'temp' undeclared (first use in this function) ppc/dsputilh264altivec.c: In function 'puth264qpel16mc01altivec': _ppc/dsputilh264altivec.c:227: error: syntax error before 'align16' ppc/dsputilh264altivec.c:227: error: 'temp' undeclared (first use in this function) ppc/dsputilh264altivec.c: In function 'puth264qpel16mc03altivec': _ppc/dsputilh264altivec.c:227: error: syntax error before 'align16' ppc/dsputilh264altivec.c:227: error: 'temp' undeclared (first use in this function) ppc/dsputilh264altivec.c: In function 'puth264qpel16mc11altivec': _ppc/dsputilh264altivec.c:227: error: syntax error before 'align16' ppc/dsputilh264altivec.c:227: error: 'temp' undeclared (first use in this function) ppc/dsputilh264altivec.c: In function 'puth264qpel16mc31altivec': _ppc/dsputilh264altivec.c:227: error: syntax error before 'align16' ppc/dsputilh264altivec.c:227: error: 'temp' undeclared (first use in this function) ppc/dsputilh264altivec.c: In function 'puth264qpel16mc13altivec': _ppc/dsputilh264altivec.c:227: error: syntax error before 'align16' ppc/dsputilh264altivec.c:227: error: 'temp' undeclared (first use in this function) ppc/dsputilh264altivec.c: In function 'puth264qpel16mc33altivec': _ppc/dsputilh264altivec.c:227: error: syntax error before 'align16' ppc/dsputilh264altivec.c:227: error: 'temp' undeclared (first use in this function) ppc/dsputilh264altivec.c: In function 'puth264qpel16mc22altivec': _ppc/dsputilh264altivec.c:227: error: syntax error before 'align16' ppc/dsputilh264altivec.c:227: error: 'temp' undeclared (first use in this function) ppc/dsputilh264altivec.c: In function 'puth264qpel16mc21altivec': _ppc/dsputilh264altivec.c:227: error: syntax error before 'align16' ppc/dsputilh264altivec.c:227: error: 'temp' undeclared (first use in this function) ppc/dsputilh264altivec.c: In function 'puth264qpel16mc23altivec': _ppc/dsputilh264altivec.c:227: error: syntax error before 'align16' ppc/dsputilh264altivec.c:227: error: 'temp' undeclared (first use in this function) ppc/dsputilh264altivec.c: In function 'puth264qpel16mc12altivec': _ppc/dsputilh264altivec.c:227: error: syntax error before 'align16' ppc/dsputilh264altivec.c:227: error: 'temp' undeclared (first use in this function) ppc/dsputilh264altivec.c: In function 'puth264qpel16mc32altivec': _ppc/dsputilh264altivec.c:227: error: syntax error before 'align16' ppc/dsputilh264altivec.c:227: error: 'temp' undeclared (first use in this function) ppc/dsputilh264altivec.c: In function 'avgh264qpel16mc10altivec': _ppc/dsputilh264altivec.c:228: error: syntax error before 'align16' ppc/dsputilh264altivec.c:228: error: 'temp' undeclared (first use in this function) ppc/dsputilh264altivec.c: In function 'avgh264qpel16mc30altivec': _ppc/dsputilh264altivec.c:228: error: syntax error before 'align16' ppc/dsputilh264altivec.c:228: error: 'temp' undeclared (first use in this function) ppc/dsputilh264altivec.c: In function 'avgh264qpel16mc01altivec': _ppc/dsputilh264altivec.c:228: error: syntax error before 'align16' ppc/dsputilh264altivec.c:228: error: 'temp' undeclared (first use in this function) ppc/dsputilh264altivec.c: In function 'avgh264qpel16mc03altivec': _ppc/dsputilh264altivec.c:228: error: syntax error before 'align16' ppc/dsputilh264altivec.c:228: error: 'temp' undeclared (first use in this function) ppc/dsputilh264altivec.c: In function 'avgh264qpel16mc11altivec': _ppc/dsputilh264altivec.c:228: error: syntax error before 'align16' ppc/dsputilh264altivec.c:228: error: 'temp' undeclared (first use in this function) ppc/dsputilh264altivec.c: In function 'avgh264qpel16mc31altivec': _ppc/dsputilh264altivec.c:228: error: syntax error before 'align16' ppc/dsputilh264altivec.c:228: error: 'temp' undeclared (first use in this function) ppc/dsputilh264altivec.c: In function 'avgh264qpel16mc13altivec': _ppc/dsputilh264altivec.c:228: error: syntax error before 'align16' ppc/dsputilh264altivec.c:228: error: 'temp' undeclared (first use in this function) ppc/dsputilh264altivec.c: In function 'avgh264qpel16mc33altivec': _ppc/dsputilh264altivec.c:228: error: syntax error before 'align16' ppc/dsputilh264altivec.c:228: error: 'temp' undeclared (first use in this function) ppc/dsputilh264altivec.c: In function 'avgh264qpel16mc22altivec': _ppc/dsputilh264altivec.c:228: error: syntax error before 'align16' ppc/dsputilh264altivec.c:228: error: 'temp' undeclared (first use in this function) ppc/dsputilh264altivec.c: In function 'avgh264qpel16mc21altivec': _ppc/dsputilh264altivec.c:228: error: syntax error before 'align16' ppc/dsputilh264altivec.c:228: error: 'temp' undeclared (first use in this function) ppc/dsputilh264altivec.c: In function 'avgh264qpel16mc23altivec': _ppc/dsputilh264altivec.c:228: error: syntax error before 'align16' ppc/dsputilh264altivec.c:228: error: 'temp' undeclared (first use in this function) ppc/dsputilh264altivec.c: In function 'avgh264qpel16mc12altivec': _ppc/dsputilh264altivec.c:228: error: syntax error before 'align16' ppc/dsputilh264altivec.c:228: error: 'temp' undeclared (first use in this function) ppc/dsputilh264altivec.c: In function 'avgh264qpel16mc32altivec': _ppc/dsputilh264altivec.c:228: error: syntax error before 'align16' ppc/dsputilh264altivec.c:228: error: 'temp' undeclared (first use in this function) make: *** [ppc/dsputilh264altivec.o] Error 1

Hopefully this new one should work. (although I can't test it on PPC) -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: portable-align_new.patch URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060202/5a25d6c9/attachment.asc>

More information about the ffmpeg-devel mailing list