Richard Guenther - Re: [PATCH][C++] Fix PR29433, make C++ use a lot less time/memory (original) (raw)

This is the mail archive of the gcc-patches@gcc.gnu.orgmailing list for the GCC project.

• From: Richard Guenther
• To: Paolo Carlini
• Cc: gcc-patches at gcc dot gnu dot org
• Date: Fri, 23 Feb 2007 10:56:17 +0100 (CET)
• Subject: Re: [PATCH][C++] Fix PR29433, make C++ use a lot less time/memory
• References: 457EF130.5040902@codesourcery.com Pine.LNX.4.64.0612131535100.29962@wotan.suse.de 4580405A.4000109@codesourcery.com <Pine.LNX.4.64.0702201500170.25448@wotan.suse.de> <20070220143731.GA8544@caradoc.them.org> <Pine.LNX.4.64.0702201602540.25448@wotan.suse.de> <45DB898E.8080401@codesourcery.com> <Pine.LNX.4.64.0702211628450.25448@wotan.suse.de> <45DC9C34.5060201@codesourcery.com> <Pine.LNX.4.64.0702221804250.25448@wotan.suse.de> <20070222214339.GD14919@atrey.karlin.mff.cuni.cz> <Pine.LNX.4.64.0702231026290.18923@zhemvz.fhfr.qr> <45DEB94E.70404@suse.de>

On Fri, 23 Feb 2007, Paolo Carlini wrote:

Richard Guenther wrote:

/sw/gcc-current/include/c++/3.4/bits/stl_tree.h:592: error: declaration of 'typedef struct std::_Rb_tree_node<_Val> std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::_Rb_tree_node' /sw/gcc-current/include/c++/3.4/bits/stl_tree.h:121: error: changes meaning of '_Rb_tree_node' from 'struct std::_Rb_tree_node<_Val>'

These errors didn't appeared previously on the preprocessed file. Perhaps I just need to regenerate, if making compiler more restrictive was intended.

Yes, that's an error in libstdc++. I have the following pending patch which allows -fpermissive to make this a warning.

Richard, I have only some very vague recollections of this issue: are we supposed to tweak a bit the library itself?!?

We already did ;)

2006-12-11 Richard Guenther rguenther@suse.de Paolo Carlini pcarlini@suse.de

    * include/ext/pb_ds/detail/pat_trie_/traits.hpp: Qualify types.
    * include/ext/pb_ds/detail/binary_heap_/binary_heap_.hpp: 

Likewise. * include/ext/rope: Likewise. * include/bits/stl_tree.h (struct _Rb_tree): Change the _Link_type typedefs to use _Rb_tree_node<_Val> directly. (_M_get_node, _M_put_node): Use _Link_type.

it might be we didn't catch all cases though, but the one honza mentioned is fixed.

Richard.

-- Richard Guenther rguenther@suse.de Novell / SUSE Labs SUSE LINUX Products GmbH - Nuernberg - AG Nuernberg - HRB 16746 - GF: Markus Rex

• References:
  • Re: [PATCH][C++] Fix PR29433, make C++ use a lot less time/memory
    * From: Michael Matz
  • Re: [PATCH][C++] Fix PR29433, make C++ use a lot less time/memory
    * From: Daniel Jacobowitz
  • Re: [PATCH][C++] Fix PR29433, make C++ use a lot less time/memory
    * From: Michael Matz
  • Re: [PATCH][C++] Fix PR29433, make C++ use a lot less time/memory
    * From: Mark Mitchell
  • Re: [PATCH][C++] Fix PR29433, make C++ use a lot less time/memory
    * From: Michael Matz
  • Re: [PATCH][C++] Fix PR29433, make C++ use a lot less time/memory
    * From: Mark Mitchell
  • Re: [PATCH][C++] Fix PR29433, make C++ use a lot less time/memory
    * From: Michael Matz
  • Re: [PATCH][C++] Fix PR29433, make C++ use a lot less time/memory
    * From: Jan Hubicka
  • Re: [PATCH][C++] Fix PR29433, make C++ use a lot less time/memory
    * From: Richard Guenther
  • Re: [PATCH][C++] Fix PR29433, make C++ use a lot less time/memory
    * From: Paolo Carlini