Bug#873822: RFS: achilles/2-9 [QA] (original) (raw)

Hallo David,

Am Freitag, den 01.09.2017, 23:31 +0100 schrieb David William Richmond Davies-Jones:

It was with compat level 10.

I cannot reproduce it here, weaked d/control to just have Build-Depends: debhelper (>= 10), libpng-dev, libsdl1.2-dev

Please upload your package to mentors and I will take a look

-- tobi

On 01/09/17 23:28, Tobias Frost wrote:

Am Freitag, den 01.09.2017, 23:01 +0100 schrieb David William Richmond Davies-Jones:

I did do an upload here I dropped the build-dep, but it threw up a warning about outdated config.{sub|guess}. Should I ignore this?

This was probably before setting compat level 10? (As said, d/compat == 10 does the magic, see https://lists.debian.o rg/d ebian-devel/2016/04/msg00018.html)

On 01/09/17 22:59, Tobias Frost wrote:

Am Freitag, den 01.09.2017, 21:14 +0100 schrieb David William Richmond Davies-Jones:

Hello

I have fixed the problems with the copyright file, deleted the stray file, and fixed the lintian warnings about encoding in desktop file and description started with synopsis.

OK

I also think that I've got everything sorted with autoreconf etc, but to be honest I always seem to have trouble and get confused with them.

With compat level 10 dh-autoreconf is default -> you do not need B- D on it or autotools-dev anymore. That should fix the warning :)

Fix this and reupload... Then we're ready, I guess!

Thanks for the package!

-- tobi

David

On 31/08/17 22:17, Tobias Frost wrote:

Control: owner -1 ! Control: tags -1 moreinfo

Hallo David,

The package is already in a nice state; many thanks for updating it!

However some fixes are required:

  • d/copyright needs fixing:   - as it says "Copyright: ?"... I think it must be  Copyright: 2000 Matthew Danish mdanish@andrew.cmu.edu   - Also the License is GPL-2+   - The license grant is not copied verbatimly 

  • d/manpage is a stray file.

  • Please (try to) fix those linitan warnings or evaluate if they are valid:

W: achilles source: useless-autoreconf-build-depends autotools- dev I: achilles source: debian-watch-file-is-missing I: achilles: hardening-no-bindnow usr/bin/achilles W: achilles: description-synopsis-starts-with-article I: achilles: desktop-entry-contains-encoding-key usr/share/applications/achilles.desktop:3 Encoding I: achilles: desktop-entry-lacks-keywords-entry usr/share/applications/achilles.desktop

-- tobi

Reply to: