Bug#868488: RFS: sokochez/0.6.2-1 ITP (original) (raw)

Please keep 868488@bugs.debian.org in To: or CC: so there's a record of review done and that others can chime in too.

On Sat, Sep 02, 2017 at 10:24:43PM +0200, Baptiste Pouget wrote:

Thank you for your help ! I now have fixed the issues you mentionned. Is there any issue left or is my package ready ?

There's no manpage for sokochez-story, nor a hint what's the difference between it and sokochez.

And, how do you even run it? No matter what options I give to it, the result is: [~]$ sokochez /usr/share/games/sokochez/maps/clear/nivoo.txt Sokochez Help Usage : [flags] level[s] -e : editor mode -h : print help

Changing bool editor; bool help; to bool editor = 0; bool help = 0; makes it at least start, but I did not pore over the code to see what other uninitialized variables you might have.

As the package doesn't work when built using the packaging you provided -- have you ever tested it?

None of provided documentation suggests what the game's objective is nor what are its rules are.

The package's description could use some fleshing out -- at least mentioning the user interface (curses-like) would be good. I'd also change the wording of "two players game" -- it suggests it's meant to be played by two people while the puzzle instead has two player-controlled characters.

But in general -- while the packaging is not far from being acceptable, the contents don't strike me as very useful in the present shape.

Meow!

⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢰⠒⠀⣿⡁ Vat kind uf sufficiently advanced technology iz dis!? ⢿⡄⠘⠷⠚⠋⠀ -- Genghis Ht'rok'din ⠈⠳⣄⠀⠀⠀⠀

Reply to: