Bug#867727: Request for sponsoring Parlatype -- audio player for transcription (original) (raw)

Hello, Gabor and Ross,

Ross Gammon kirjoitti 10.09.2017 klo 13:15:

I would be happy to take a look at this. Unfortunately, I am quite busy at the moment so I can't promise much this week.

I have cc'd you because you did not say whether you are subscribed to the Multimedia list. I have also copied in the RFS bug so that other potential sponsors see this and take over if they are looking for something to do :-)

Regards,

Ross

I can review the package and offer my comments in the meantime. Disclaimer: I am not Debian Developer or Debian Maintainer.

Gabor,

Your package is not lintian-clean, please investigate (lintian -EviI --pedantic) and fix what you can.

debian/control: I think Section: sound would be more suitable than Section: gnome. You can drop some version requirements, please run 'cme check dpkg'. Latest Policy version is 4.1.0. Please use https for the homepage address.

The Debian changelog for new packages is usually very simple. This should be enough:

parlatype (1.5.2-1) unstable; urgency=medium

  * Initial release (Closes: #868886)

 -- Gabor Karsay   Thu, 10 Aug 2017 17:43:18 +0200

debian/copyright should use the established short license names, i.e. GPL-3+ for "version 3 or later" and CC-BY-SA-4, not CCBYSA-4. They are listed in the format specification.For the CC licenses, I think it is not enough to just refer to a web page, as the terms must be readable offline.

See if any http URL can be changed to https in this file, too.

In debian/rules, based on my testing, I can tell these two lines are not needed:

DPKG_EXPORT_BUILDFLAGS = 1 include /usr/share/dpkg/buildflags.mk

Otherwise, the package looks very good to me.

With best regards, Juhani

Reply to: