Bug#869806: Update (original) (raw)
- To: Adam Borowski <kilobyte@angband.pl>
- Cc: 869806@bugs.debian.org
- Subject: Bug#869806: Update
- From: Julien Hartmann <juli1.hartmann@gmail.com>
- Date: Fri, 22 Sep 2017 12:28:34 +0000
- Message-id: <[🔎] CACYXcAoLd8x2Or9PBGn4sir0oBZvCpF=VodxHpG=rj88XYahOg@mail.gmail.com>
- Reply-to: Julien Hartmann <juli1.hartmann@gmail.com>, 869806@bugs.debian.org
- In-reply-to: <[🔎] 20170921214342.3y2aiord6xo5tydi@angband.pl>
- References: <CACYXcApi9f7_6vfdnNUUz1gcso=d345VaN9fFwbCwav1pg1ibQ@mail.gmail.com> <[🔎] CACYXcAqph+VJ+gjbr_ZLFcmvm=7Gdcja26JHa6rFmMV-M7LtZQ@mail.gmail.com> <[🔎] 20170921214342.3y2aiord6xo5tydi@angband.pl> <CACYXcApi9f7_6vfdnNUUz1gcso=d345VaN9fFwbCwav1pg1ibQ@mail.gmail.com>
Hello,
Noted, I'll keep updating there then, hoping for the best.
Thanks for taking the time to try and build it. Yes, gaming keyboards expose a second HID interface to deal with non-standard features, and that's the one keyleds talks to. So it just shouldn't find any device if no gaming keyboard is connected.
Being able to build it on non-x86 platforms is definitely part of the objectives. It was created with this in mind, though actual tests are still on the "TODO" side of the list. I missed the fact that __builtin_cpu_init only exists on platforms where gcc actually detects things. I'm opening an issue for this and fix will be in next release.
Thanks!
On Thu, Sep 21, 2017 at 9:43 PM, Adam Borowski kilobyte@angband.pl wrote:
On Thu, Sep 21, 2017 at 01:17:57PM +0000, Julien Hartmann wrote:
Hello, I updated the package from upstream. I don't know if I am supposed to file another RFS or just append to this one?
The previous one hasn't been sponsored yet, so you're merely updating the request rather than asking for a new upload. Appending to the RFS bug is preferred. One sponsored upload -- one RFS.
New version is 0.4.3-1. It can be downloaded with dget -x https://mentors.debian.net/debian/pool/main/k/keyleds/keyleds_0.4.3-1.dsc
I see you're going to have trouble finding someone who can meaningfully review the package: it can't be tested without relevant hardware. I for one have a non-gaming Logitech keyboard, this daemon doesn't speak to it (not surprising -- no LEDs other than Num/Caps/Scroll).
The package fails to build on architectures other than amd64 and i386, as its code to detect ISA extensions uses x86-only features despite obvious attempts of the build system to be portable. It'd be nice to fix this as fancy-schmancy keyboards are in no way x86-specific: you can attach one both to an 89Pinebook(arm64)ortoa89 Pinebook (arm64) or to a 89Pinebook(arm64)ortoa6.5k Talos 2 (ppc64el).
Meow!
⢀⣴⠾⠻⢶⣦⠀ I've read an article about how lively happy music boosts ⣾⠁⢰⠒⠀⣿⡁ productivity. You can read it, too, you just need the ⢿⡄⠘⠷⠚⠋⠀ right music while doing so. I recommend Skepticism ⠈⠳⣄⠀⠀⠀⠀ (funeral doom metal).
Reply to:
- Follow-Ups:
- Bug#869806: Update
* From: Julien Hartmann juli1.hartmann@gmail.com
- Bug#869806: Update
- References:
- Bug#869806: Update
* From: Julien Hartmann juli1.hartmann@gmail.com - Bug#869806: Update
* From: Adam Borowski kilobyte@angband.pl
- Bug#869806: Update
- Prev by Date:Bug#867727: RFS: parlatype/1.5.2-1 [ITP]
- Next by Date:Bug#875997: marked as done (RFS: jclicmoodle/3.0.1-1 (package already in Debian from 2009))
- Previous by thread:Bug#869806: Update
- Next by thread:Bug#869806: Update
- Index(es):