[Python-Dev] Re: python/dist/src/Objectsunicodeobject.c, 2.204, 2.205 (original) (raw)

Skip Montanaro skip at pobox.com
Sat Dec 20 20:07:32 EST 2003 

>> #if UCHAR_MAX != 255
>> #error "Python's source code currently assumes 8-bit characters."
>> #endif
>> 
>> right after the HAVE_LIMITS_H test?

Tim> I wouldn't object.  It should probably then also have

Tim> #ifndef UCHAR_MAX
Tim> #error ...
Tim> #endif

Isn't that supposed to always be defined in limits.h or is UCHAR_MAX not a standard macro?

Tim> right before it, and stringobject.c's

Tim> #if !defined(HAVE_LIMITS_H) && !defined(UCHAR_MAX)
Tim> #define UCHAR_MAX 255
Tim> #endif

Tim> should go away.

Sounds like a plan. I modify my local source and see if it affects anything.

Skip

More information about the Python-Dev mailing list