[Python-Dev] potential argparse problem: bad mix of parse_known_args and prefix matching (original) (raw)
Eli Bendersky eliben at gmail.com
Wed Nov 27 15:35:13 CET 2013
- Previous message: [Python-Dev] potential argparse problem: bad mix of parse_known_args and prefix matching
- Next message: [Python-Dev] [Python-checkins] cpython: asyncio: Change write buffer use to avoid O(N**2). Make write()/sendto() accept
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Tue, Nov 26, 2013 at 9:30 AM, Eli Bendersky <eliben at gmail.com> wrote:
Hello,
argparse does prefix matching as long as there are no conflicts. For example: argparser = argparse.ArgumentParser() argparser.addargument('--sync-foo', action='storetrue') args = argparser.parseargs() If I pass "--sync" to this script, it recognizes it as "--sync-foo". This behavior is quite surprising although I can see the motivation for it. At the very least it should be much more explicitly documented (AFAICS it's barely mentioned in the docs). If there's another argument registered, say "--sync-bar" the above will fail due to a conflict. Now comes the nasty part. When using "parseknownargs" instead of "parseargs", the above happens too - --sync is recognized for --sync-foo and captured by the parser. But this is wrong! The whole idea of parseknownargs is to parse the known args, leaving unknowns alone. This prefix matching harms more than it helps here because maybe the program we're actually acting as a front-end for (and hence using parseknownargs) knows about --sync and wants to get it. Unless I'm missing something, this is a bug. But I'm also not sure whether we can do anything about it at this point, as existing code may be relying on it. The right thing to do would be to disable this prefix matching when parseknownargs is called. Again, at the very least this should be documented (for parseknownargs not less than a warning box, IMHO).
I created http://bugs.python.org/issue19814 for the documentation patch.
http://bugs.python.org/issue14910 deals with making prefix matching optional, but that will have to be deferred to 3.5
Eli -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.python.org/pipermail/python-dev/attachments/20131127/63f557ab/attachment.html>
- Previous message: [Python-Dev] potential argparse problem: bad mix of parse_known_args and prefix matching
- Next message: [Python-Dev] [Python-checkins] cpython: asyncio: Change write buffer use to avoid O(N**2). Make write()/sendto() accept
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]