[Python-Dev] [Python-checkins] cpython: Issue #19330: Handle the no-docstrings case in tests (original) (raw)

Nick Coghlan ncoghlan at gmail.com
Sat Oct 26 19:41:48 CEST 2013

On 27 October 2013 03:32, Nick Coghlan <ncoghlan at gmail.com> wrote:

On 27 October 2013 01:10, Serhiy Storchaka <storchaka at gmail.com> wrote:

26.10.13 15:50, Stefan Krah написав(ла):

nick.coghlan <python-checkins at python.org> wrote:

http://hg.python.org/cpython/rev/a9bbc2d0c1dc -HAVEDOCSTRINGS = (checkimpldetail(cpython=False) or - sys.platform == 'win32' or - sysconfig.getconfigvar('WITHDOCSTRINGS')) +# Rather than trying to enumerate all the cases where docstrings may be +# disabled, we just check for that directly + +def checkdocstrings(): + """Just used to check if docstrings are enabled""" + +HAVEDOCSTRINGS = (checkdocstrings.doc is not None) requiresdocstrings = unittest.skipUnless(HAVEDOCSTRINGS,

I think that does not detect --without-doc-strings (i.e. the C docstrings are empty). Indeed. HAVEDOCSTRINGS was introduced to skip tests for the C docstrings. Python docstrings tests are skipped if sys.flags.optimize >= 2. That's extraordinarily confusing, especially when Serhiy suggested I use the flag when testing a pure Python module.

http://bugs.python.org/issue19412

Cheers, Nick.

-- Nick Coghlan | ncoghlan at gmail.com | Brisbane, Australia

More information about the Python-Dev mailing list