[Python-Dev] cpython: Issue #18408: Add a new PyFrame_FastToLocalsWithError() function to handle (original) (raw)

Antoine Pitrou solipsis at pitrou.net
Tue Oct 29 10:47:16 CET 2013

Le Tue, 29 Oct 2013 10:38:23 +0100, Victor Stinner <victor.stinner at gmail.com> a écrit :

2013/10/29 Georg Brandl <g.brandl at gmx.net>: > Am 29.10.2013 01:19, schrieb victor.stinner: >> http://hg.python.org/cpython/rev/4ef4578db38a >> changeset: 86715:4ef4578db38a >> user: Victor Stinner <victor.stinner at gmail.com> >> date: Tue Oct 29 01:19:37 2013 +0100 >> summary: >> Issue #18408: Add a new PyFrameFastToLocalsWithError() function >> to handle exceptions when merging fast locals into flocals of a >> frame. PyEvalGetLocals() now raises an exception and return NULL >> on failure. > > You'll have to either make this private or document it. > > Georg

I didn't find the documentation of PyFrameFastToLocals(). Please open an issue if you consider that these functions must be documented.

Just because something else isn't documented doesn't mean new APIs shouldn't be documented. Please let's not enter such a vicious circle.

IMO these functions should be private because very low-level, but it's too late: PyFrameFastToLocals() is part of the stable ABI, even if it's not documented.

It's not too late for PyFrame_FastToLocalsWithError() to be private, though. I agree with Georg: you should either make it private or document it.

Regards

Antoine.

More information about the Python-Dev mailing list