[Python-Dev] cpython: Issue #18408: Add a new PyFrame_FastToLocalsWithError() function to handle (original) (raw)
Georg Brandl g.brandl at gmx.net
Tue Oct 29 13:45:25 CET 2013
- Previous message: [Python-Dev] cpython: Issue #18408: Add a new PyFrame_FastToLocalsWithError() function to handle
- Next message: [Python-Dev] cpython: Issue #18408: Fix PyUnicode_AsUTF8AndSize(), raise MemoryError exception on
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Gesendet: Dienstag, 29. Oktober 2013 um 10:38 Uhr Von: "Victor Stinner" <victor.stinner at gmail.com> An: "Georg Brandl" <g.brandl at gmx.net> Cc: "Python Dev" <python-dev at python.org> Betreff: Re: [Python-Dev] cpython: Issue #18408: Add a new PyFrameFastToLocalsWithError() function to handle
2013/10/29 Georg Brandl <g.brandl at gmx.net>: > Am 29.10.2013 01:19, schrieb victor.stinner: >> http://hg.python.org/cpython/rev/4ef4578db38a >> changeset: 86715:4ef4578db38a >> user: Victor Stinner <victor.stinner at gmail.com> >> date: Tue Oct 29 01:19:37 2013 +0100 >> summary: >> Issue #18408: Add a new PyFrameFastToLocalsWithError() function to handle >> exceptions when merging fast locals into flocals of a frame. >> PyEvalGetLocals() now raises an exception and return NULL on failure. > > You'll have to either make this private or document it. > > Georg I didn't find the documentation of PyFrameFastToLocals(). Please open an issue if you consider that these functions must be documented.
I see you opened one already; thanks for that. In any case, our policy is that all public API function (those without _Py prefixes) should be documented.
IMO these functions should be private because very low-level, but it's too late: PyFrameFastToLocals() is part of the stable ABI, even if it's not documented.
Thankfully not; all of frameobject.h is not part of the stable ABI.
cheers, Georg
- Previous message: [Python-Dev] cpython: Issue #18408: Add a new PyFrame_FastToLocalsWithError() function to handle
- Next message: [Python-Dev] cpython: Issue #18408: Fix PyUnicode_AsUTF8AndSize(), raise MemoryError exception on
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]