[MWAR-444] Update plugin (requires Maven 3.2.5+) by cstamas · Pull Request #20 · apache/maven-war-plugin (original) (raw)
Move maven to proper scope, update dependencies, remove unused ones.
| 3.5.1 |
|---|
| 3.1.1 |
| 3.1.0 |
| 3.2.5 |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this required? Personally I'm OK with it. However mostly I think we've been setting 3.1.1 as out minimum lately.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is requirement dictated by maven-plugin-testing-harness v 3.3.0
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can stay with p-p-testing 3.1.0 as for the other 3.1.1. based plugins. Unfortunately, if the resources plugin will go for 3.2 then 3.2 will be our minimal version for everything (no other 3.x rel if we want to remove on 2.x plugins)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I'm OK with that. In fact, I'd be willing to go at least as far as 3.3 as a minimum. Is it worth asking on the dev list to see if we can get consensus on this as a cross-project minimum from now on?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, agree. i have same opinion here
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I even have another opinion. When Maven 3.9.0 will be released by end of this year I would base ALL baseline to 3.5.4 and burry anything below. There is no reason to support 8-year old Maven. Maven 3.5.4 will be 3,5 years old by then.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like there's a package manager I've encountered in the recent past (brew? Debian apt-get?) that installs 3.3.x by default. That's why I chose that version.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like there's a package manager I've encountered in the recent past (brew? Debian apt-get?) that installs 3.3.x by default. That's why I chose that version.
That is purely a Debian problem. Moreover, Debien screws up Maven to FUBAR.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brew on Mac OS install the latest version of Maven
Update plugin [MWAR-444] Update plugin (requires Maven 3.2.5+)
| org.codehaus.plexus |
|---|
| plexus-archiver |
| 4.2.2 |
| 4.2.5 |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4.2.7 is out
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4.2.7 is out
But until the maven-war-plugin uses Java 8, that would require to downgrade commons-compress and plexus-utils, and my guess is that to simplify transitive dependency management, this just sets the latest that has bytecode 51.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are moving everything to 8
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, yet this project is still Java 7:
| <javaVersion>7</javaVersion> |
|---|
So, ideally bump here to Java 8 and update plexus-archiver to 4.2.7, or bump it on another PR.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR opened #23
dennisl added a commit to mdh-se/maven-war-plugin that referenced this pull request
Merge pull request apache#20 from apache/update-plugin
1 similar comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})