[Arm64] Base HW Intrinsics by sdmaclea · Pull Request #16822 · dotnet/coreclr (original) (raw)

By company size
- Enterprises
- Small and medium teams
- Startups
- Nonprofits
  By use case
- DevSecOps
- DevOps
- CI/CD
- View all use cases
  By industry
- Healthcare
- Financial services
- Manufacturing
- Government
- View all industries
  View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
  Explore
- Learning Pathways
- Events & Webinars
- Ebooks & Whitepapers
- Customer Stories
- Partners
- Executive Insights
- GitHub Sponsors Fund open source developers
- The ReadME Project GitHub community articles
  Repositories
- Topics
- Trending
- Collections
Pricing

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

This repository was archived by the owner on Jan 23, 2023. It is now read-only.

dotnet / coreclr Public archive

Notifications You must be signed in to change notification settings
Fork2.6k
Star 12.8k
Code
Pull requests
Security
Insights

Additional navigation options

Merged

CarolEidt merged 2 commits intodotnet:masterfromsdmaclea:PR-ARM64-BASE-INTRINSICS

Mar 13, 2018

Merged

[Arm64] Base HW Intrinsics #16822

CarolEidt merged 2 commits intodotnet:masterfromsdmaclea:PR-ARM64-BASE-INTRINSICS

Mar 13, 2018

Conversation5 Commits2 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Copy link

@sdmaclea sdmaclea commented

Mar 8, 2018

@dotnet/arm64-contrib @CarolEidt @RussKeldorph @eerhardt @tannergooding PTAL

4creators reacted with thumbs up emoji

[[Arm64] Add Base HW intrinsics](/dotnet/coreclr/pull/16822/commits/9b8e675bffa338a849c76687f134acfd26c85d1e "[Arm64] Add Base HW intrinsics")

[9b8e675](/dotnet/coreclr/pull/16822/commits/9b8e675bffa338a849c76687f134acfd26c85d1e)

sdmaclea commented Mar 8, 2018

View reviewed changes

tests/src/JIT/HardwareIntrinsics/Arm64/Base.cs Outdated


// Reflection call
var issupported = "get_IsSupported";
bool reflectedIsSupported = Convert.ToBoolean(typeof(Simd).GetMethod(issupported).Invoke(null, null));

Copy link

Author

@sdmaclea sdmaclea

Mar 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simd should be Base

sdmaclea force-pushed the PR-ARM64-BASE-INTRINSICS branch from1c6f74f tod8ac38e Compare

March 8, 2018 17:05

CarolEidt approved these changes Mar 8, 2018

View reviewed changes

Copy link

@CarolEidt CarolEidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I would like to see us improve the tests to get broader coverage, but I'm OK with leaving that for future.

[[Arm64] Add Base HW intrinsic tests](/dotnet/coreclr/pull/16822/commits/40f7302f227f7fde344e1e586b1eb31300946120 "[Arm64] Add Base HW intrinsic tests")

[40f7302](/dotnet/coreclr/pull/16822/commits/40f7302f227f7fde344e1e586b1eb31300946120)

sdmaclea force-pushed the PR-ARM64-BASE-INTRINSICS branch fromd8ac38e to40f7302 Compare

March 10, 2018 21:39