Use simple Array.Copy overload where possible by jkotas · Pull Request #27641 · dotnet/coreclr (original) (raw)

Skip to content

Navigation Menu

Sign in

Appearance settings

• • GitHub Copilot Write better code with AI
  • GitHub Models New Manage and compare prompts
  • GitHub Advanced Security Find and fix vulnerabilities
  • Actions Automate any workflow
  • Codespaces Instant dev environments
  • Issues Plan and track work
  • Code Review Manage code changes
  • Discussions Collaborate outside of code
  • Code Search Find more, search less
    Explore
  • Why GitHub
  • All features
  • Documentation
  • GitHub Skills
  • Blog
• By company size
  • Enterprises
  • Small and medium teams
  • Startups
  • Nonprofits
    By use case
  • DevSecOps
  • DevOps
  • CI/CD
  • View all use cases
    By industry
  • Healthcare
  • Financial services
  • Manufacturing
  • Government
  • View all industries
    View all solutions
• Topics
  • AI
  • DevOps
  • Security
  • Software Development
  • View all
    Explore
  • Learning Pathways
  • Events & Webinars
  • Ebooks & Whitepapers
  • Customer Stories
  • Partners
  • Executive Insights
• • GitHub Sponsors Fund open source developers
  • The ReadME Project GitHub community articles
    Repositories
  • Topics
  • Trending
  • Collections
• • Enterprise platform AI-powered developer platform
    Available add-ons
  • GitHub Advanced Security Enterprise-grade security features
  • Copilot for business Enterprise-grade AI features
  • Premium Support Enterprise-grade 24/7 support
• Pricing

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

This repository was archived by the owner on Jan 23, 2023. It is now read-only.

dotnet / coreclr Public archive

• Notifications You must be signed in to change notification settings

• Fork2.6k

• Star 12.8k

• Code

• Pull requests

• Security

• Insights

Additional navigation options

Merged

stephentoub merged 1 commit intodotnet:masterfromjkotas:use-simple-array-copy

Nov 3, 2019

Merged

Use simple Array.Copy overload where possible #27641

stephentoub merged 1 commit intodotnet:masterfromjkotas:use-simple-array-copy

Nov 3, 2019

Conversation0 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Copy link

Member

jkotas commented

Nov 3, 2019

The simple Array.Copy overload does not come with a performance penalty anymore.

`[Use simple Array.Copy overload where possible](/dotnet/coreclr/pull/27641/commits/8ab60c08bd4b8ebfe7025516a2959dded2d45942 "Use simple Array.Copy overload where possible

The simple Array.Copy overload does not come with a performance penalty anymore.") `

[8ab60c0](/dotnet/coreclr/pull/27641/commits/8ab60c08bd4b8ebfe7025516a2959dded2d45942)

The simple Array.Copy overload does not come with a performance penalty anymore.

jkotas requested a review from stephentoub

November 3, 2019 05:29

jkotas added the area-Meta-corelib label

Nov 3, 2019

stephentoub approved these changes Nov 3, 2019

View reviewed changes

stephentoub merged commit 27b334b into dotnet:master

Nov 3, 2019

Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corert that referenced this pull request

Nov 3, 2019

`[Use simple Array.Copy overload where possible (](/Dotnet-GitSync-Bot/corert/commit/561651717ae1de5337bac1d0b8b0690c72d29b35 "Use simple Array.Copy overload where possible (dotnet/coreclr#27641)

The simple Array.Copy overload does not come with a performance penalty anymore.

Signed-off-by: dotnet-bot dotnet-bot@microsoft.com")dotnet/coreclr#27641[)](/Dotnet-GitSync-Bot/corert/commit/561651717ae1de5337bac1d0b8b0690c72d29b35 "Use simple Array.Copy overload where possible (dotnet/coreclr#27641)

The simple Array.Copy overload does not come with a performance penalty anymore.

Signed-off-by: dotnet-bot dotnet-bot@microsoft.com") `

[5616517](/Dotnet-GitSync-Bot/corert/commit/561651717ae1de5337bac1d0b8b0690c72d29b35)

The simple Array.Copy overload does not come with a performance penalty anymore.

Signed-off-by: dotnet-bot dotnet-bot@microsoft.com

Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corefx that referenced this pull request

Nov 3, 2019

`[Use simple Array.Copy overload where possible (](/Dotnet-GitSync-Bot/corefx/commit/97c3e57cd8b4b197f7acd8b8394e9c698b6232f5 "Use simple Array.Copy overload where possible (dotnet/coreclr#27641)

The simple Array.Copy overload does not come with a performance penalty anymore.

Signed-off-by: dotnet-bot dotnet-bot@microsoft.com")dotnet/coreclr#27641[)](/Dotnet-GitSync-Bot/corefx/commit/97c3e57cd8b4b197f7acd8b8394e9c698b6232f5 "Use simple Array.Copy overload where possible (dotnet/coreclr#27641)

The simple Array.Copy overload does not come with a performance penalty anymore.

Signed-off-by: dotnet-bot dotnet-bot@microsoft.com") `

[97c3e57](/Dotnet-GitSync-Bot/corefx/commit/97c3e57cd8b4b197f7acd8b8394e9c698b6232f5)

The simple Array.Copy overload does not come with a performance penalty anymore.

Signed-off-by: dotnet-bot dotnet-bot@microsoft.com

jkotas deleted the use-simple-array-copy branch

November 3, 2019 14:53

Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/mono that referenced this pull request

Nov 3, 2019

`[Use simple Array.Copy overload where possible (](/Dotnet-GitSync-Bot/mono/commit/0b839ac2247796925c867d0b61fa1fc6685ea3a4 "Use simple Array.Copy overload where possible (dotnet/coreclr#27641)

The simple Array.Copy overload does not come with a performance penalty anymore.

Signed-off-by: dotnet-bot dotnet-bot@microsoft.com")dotnet/coreclr#27641[)](/Dotnet-GitSync-Bot/mono/commit/0b839ac2247796925c867d0b61fa1fc6685ea3a4 "Use simple Array.Copy overload where possible (dotnet/coreclr#27641)

The simple Array.Copy overload does not come with a performance penalty anymore.

Signed-off-by: dotnet-bot dotnet-bot@microsoft.com") `

[0b839ac](/Dotnet-GitSync-Bot/mono/commit/0b839ac2247796925c867d0b61fa1fc6685ea3a4)

The simple Array.Copy overload does not come with a performance penalty anymore.

Signed-off-by: dotnet-bot dotnet-bot@microsoft.com

jkotas added a commit to dotnet/corert that referenced this pull request

Nov 3, 2019

`[Use simple Array.Copy overload where possible (](/dotnet/corert/commit/e32a6b830670deb0f18738e3a4ca0b3d1c0a94d3 "Use simple Array.Copy overload where possible (dotnet/coreclr#27641)

The simple Array.Copy overload does not come with a performance penalty anymore.

Signed-off-by: dotnet-bot dotnet-bot@microsoft.com")dotnet/coreclr#27641[)](/dotnet/corert/commit/e32a6b830670deb0f18738e3a4ca0b3d1c0a94d3 "Use simple Array.Copy overload where possible (dotnet/coreclr#27641)

The simple Array.Copy overload does not come with a performance penalty anymore.

Signed-off-by: dotnet-bot dotnet-bot@microsoft.com") `

[e32a6b8](/dotnet/corert/commit/e32a6b830670deb0f18738e3a4ca0b3d1c0a94d3)

The simple Array.Copy overload does not come with a performance penalty anymore.

Signed-off-by: dotnet-bot dotnet-bot@microsoft.com

stephentoub pushed a commit to dotnet/corefx that referenced this pull request

Nov 3, 2019

`[Use simple Array.Copy overload where possible (](/dotnet/corefx/commit/bf4b04519cb86facf793797406910cbd40cf2354 "Use simple Array.Copy overload where possible (dotnet/coreclr#27641)

The simple Array.Copy overload does not come with a performance penalty anymore.

Signed-off-by: dotnet-bot dotnet-bot@microsoft.com")dotnet/coreclr#27641[)](/dotnet/corefx/commit/bf4b04519cb86facf793797406910cbd40cf2354 "Use simple Array.Copy overload where possible (dotnet/coreclr#27641)

The simple Array.Copy overload does not come with a performance penalty anymore.

Signed-off-by: dotnet-bot dotnet-bot@microsoft.com") `

[bf4b045](/dotnet/corefx/commit/bf4b04519cb86facf793797406910cbd40cf2354)

The simple Array.Copy overload does not come with a performance penalty anymore.

Signed-off-by: dotnet-bot dotnet-bot@microsoft.com

stephentoub mentioned this pull request

Nov 4, 2019

Simplify Array.Copy(a, 0, b, 0, c) to Array.Copy(a, b, c)dotnet/corefx#42343

Merged

marek-safar pushed a commit to mono/mono that referenced this pull request

Nov 4, 2019

`[Use simple Array.Copy overload where possible (](/mono/mono/commit/deb3115b15db9aa87816e64edf118aeca5feb8bd "Use simple Array.Copy overload where possible (dotnet/coreclr#27641)

The simple Array.Copy overload does not come with a performance penalty anymore.

Signed-off-by: dotnet-bot dotnet-bot@microsoft.com")dotnet/coreclr#27641[)](/mono/mono/commit/deb3115b15db9aa87816e64edf118aeca5feb8bd "Use simple Array.Copy overload where possible (dotnet/coreclr#27641)

The simple Array.Copy overload does not come with a performance penalty anymore.

Signed-off-by: dotnet-bot dotnet-bot@microsoft.com") `

[deb3115](/mono/mono/commit/deb3115b15db9aa87816e64edf118aeca5feb8bd)

The simple Array.Copy overload does not come with a performance penalty anymore.

Signed-off-by: dotnet-bot dotnet-bot@microsoft.com

jkotas mentioned this pull request

Feb 15, 2020

Go through ImmutableArray and switch manual looping to Array.Copydotnet/runtime#32373

Closed

Sign up for free to subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

stephentoub stephentoub approved these changes

Assignees

No one assigned

Labels

area-Meta-corelib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants