Rewrite the rest of the array non-generic fast paths in C# by jkotas · Pull Request #27703 · dotnet/coreclr (original) (raw)

Appearance settings

By company size
- Enterprises
- Small and medium teams
- Startups
- Nonprofits
  By use case
- DevSecOps
- DevOps
- CI/CD
- View all use cases
  By industry
- Healthcare
- Financial services
- Manufacturing
- Government
- View all industries
  View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
  Explore
- Learning Pathways
- Events & Webinars
- Ebooks & Whitepapers
- Customer Stories
- Partners
- Executive Insights
- GitHub Sponsors Fund open source developers
- The ReadME Project GitHub community articles
  Repositories
- Topics
- Trending
- Collections
Pricing

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

This repository was archived by the owner on Jan 23, 2023. It is now read-only.

dotnet / coreclr Public archive

Notifications You must be signed in to change notification settings
Fork2.6k
Star 12.8k
Code
Pull requests
Security
Insights

Additional navigation options

Merged

jkotas merged 7 commits intodotnet:masterfromjkotas:nongeneric-array

Nov 9, 2019

Merged

Rewrite the rest of the array non-generic fast paths in C# #27703

jkotas merged 7 commits intodotnet:masterfromjkotas:nongeneric-array

Nov 9, 2019

Conversation18 Commits7 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Copy link

Member

@jkotas jkotas commented

Nov 6, 2019

No description provided.

filipnavara and pentp reacted with thumbs up emoji MarcoRossignoli reacted with heart emoji

[Rewrite the rest of the array non-generic fast paths in C#](/dotnet/coreclr/pull/27703/commits/e66ab7a605bbde89617dd5b0a2c0df05936b2e4e "Rewrite the rest of the array non-generic fast paths in C#")

[e66ab7a](/dotnet/coreclr/pull/27703/commits/e66ab7a605bbde89617dd5b0a2c0df05936b2e4e)

jkotas commented Nov 6, 2019

View reviewed changes

src/System.Private.CoreLib/shared/System/Array.cs Outdated Show resolved Hide resolved

jkotas commented Nov 6, 2019

View reviewed changes

src/System.Private.CoreLib/shared/System/Array.cs Outdated Show resolved Hide resolved

jkotas commented Nov 6, 2019

View reviewed changes

src/System.Private.CoreLib/shared/System/Array.cs Show resolved Hide resolved

jkotas requested a review from stephentoub

November 6, 2019 09:40

[Add missing resource string](/dotnet/coreclr/pull/27703/commits/14ade0ea0969656fbe3aeeeba350b8850cc38e80 "Add missing resource string")

[14ade0e](/dotnet/coreclr/pull/27703/commits/14ade0ea0969656fbe3aeeeba350b8850cc38e80)

stephentoub reviewed Nov 6, 2019

View reviewed changes

src/System.Private.CoreLib/shared/System/Array.cs Show resolved Hide resolved

stephentoub approved these changes Nov 6, 2019

View reviewed changes

Copy link

Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

stephentoub mentioned this pull request

Nov 6, 2019

Remove string special-casing from non-generic sort#27706

Closed

danmoseley added the area-System.Runtime label

Nov 6, 2019

lpereira previously approved these changes Nov 6, 2019

View reviewed changes

src/System.Private.CoreLib/shared/System/Array.cs Show resolved Hide resolved

lpereira dismissed their stale review

November 6, 2019 20:43

Didn't mean to approve this yet (just ask a question.)

Copy link

maryamariyan commented

Nov 6, 2019

Thank you for your contribution. As announced in dotnet/coreclr#27549 this repository will be moving to dotnet/runtime on November 13. If you would like to continue working on this PR after this date, the easiest way to move the change to dotnet/runtime is:

In your coreclr repository clone, create patch by running git format-patch origin
In your runtime repository clone, apply the patch by running git apply --directory src/coreclr <path to the patch created in step 1>

[Bugfixes](/dotnet/coreclr/pull/27703/commits/8eeb5cf2d7dc9692bfc919629ee22d7ba60e4811 "Bugfixes")

[8eeb5cf](/dotnet/coreclr/pull/27703/commits/8eeb5cf2d7dc9692bfc919629ee22d7ba60e4811)

stephentoub reviewed Nov 7, 2019

View reviewed changes

src/System.Private.CoreLib/shared/System/RuntimeType.cs Show resolved Hide resolved

AaronRobinsonMSFT approved these changes Nov 7, 2019

View reviewed changes

src/System.Private.CoreLib/shared/System/Array.cs Show resolved Hide resolved

jkotas added 2 commits

November 6, 2019 22:42

[Use CorElementType and handle native ints to match the unmanaged impl…](/dotnet/coreclr/pull/27703/commits/84f7b785856426a1345994eec9a49a7381767d97 "Use CorElementType and handle native ints to match the unmanaged implementation")

[84f7b78](/dotnet/coreclr/pull/27703/commits/84f7b785856426a1345994eec9a49a7381767d97)

…ementation

[Avoid try pattern for Sort and Reverse](/dotnet/coreclr/pull/27703/commits/8b0e4d93c60370d95f94e2d39400d958c7e4f058 "Avoid try pattern for Sort and Reverse")

[8b0e4d9](/dotnet/coreclr/pull/27703/commits/8b0e4d93c60370d95f94e2d39400d958c7e4f058)

jkotas added the * NO MERGE *

The PR is not ready for merge yet (see discussion for detailed reasons)

label

Nov 7, 2019

[Match the native implementation more closely](/dotnet/coreclr/pull/27703/commits/6cfe29e54305173bd2e5393b4ae12877736a1bb6 "Match the native implementation more closely")

[6cfe29e](/dotnet/coreclr/pull/27703/commits/6cfe29e54305173bd2e5393b4ae12877736a1bb6)

jkotas removed the * NO MERGE *

The PR is not ready for merge yet (see discussion for detailed reasons)

label

Nov 8, 2019